| commit | cfc140e365974490f4508c5301f88f7332dab2e5 | [log] [tgz] |
|---|---|---|
| author | David Pursehouse <dpursehouse@collab.net> | Tue Nov 13 16:53:41 2018 -0800 |
| committer | David Pursehouse <dpursehouse@collab.net> | Tue Nov 13 17:17:38 2018 -0800 |
| tree | a130296d8dbfaf053f9ab208416ac815197b34e9 | |
| parent | f418bcf7ee59b7e1f2f5dc2030374efb34e42709 [diff] | |
| parent | d9e39bf8871c3a994ce33d0463d3170da4ccb8a2 [diff] |
Merge branch 'stable-2.15' * stable-2.15: Upgrade bazlets to latest stable-2.15 to build with 2.15.7 API Remove tools/bazel.rc Bazel: Fix standalone build Add "Empty file" comments in empty BUILD files ConfigurationParser: Format with google-java-format Fix owners e-mail matching on LDAP Allow OWNERS file with single owner Revert "Fix label name generated by workskace-status.sh" Bazel: Add standalone build mode Fix label name generated by workskace-status.sh Ignore /MERGE_LIST when looking for owners Upgrade bazlets to latest stable-2.14 to build with 2.14.16 API Align Eclipse compiler settings with core Gerrit's Replace wildcard imports with explicit imports Upgrade jackson to 2.9.7 bazlets: Replace native.git_repository with skylark rule Upgrade bazlets to latest stable-2.14 to build with 2.14.15 API Format all Bazel build files with buildifier Migrate (i.e. move) `tools/bazel.rc` to `.bazelrc` Update bazlets to latest stable-2.14 to build with 2.14.14 API Update bazlets to latest stable-2.14 to build with 2.14.13 API Don't include jackson-core in shaded JAR Align jackson version with core Gerrit Check null account full name Format all BUILD files with buildifier 0.12.0 Fix in-tree build Adjust to renamed dependencies in core Fix names of build output jar files in README Adjust to renamed dependencies in core Update bazlets to latest revision on stable-2.14 Filter out inactive accounts in OWNERS Bazel: Add standalone build mode Does not include jackson-core in the final artifacts Sync Jackson lib version with Gerrit Fix owners dependencies Remove duplicated build dependencies Reformat build files Remove Buck build Fix config documentation Fix Eclipse warnings Cleanup .gitignore file Eager initialize Owners Prolog Predicates Consider name and e-mail matching edge cases Batch sending mail when multiple reviewers added Also update WORKSPACE to build with the 2.16-rc3 API. Change-Id: Iff88759f91d630964ce5f3ec92ad6495adbd836b
This plugin provides some Prolog predicates that can be used to add customized validation checks based on the approval of ‘path owners’ of a particular folder in the project.
That allows creating a single big project including multiple components and users have different roles depending on the particular path where changes are being proposed. A user can be “owner” in a specific directory, and thus influencing the approvals of changes there, but cannot do the same in others paths, so assuring a kind of dynamic subproject access rights.
There are currently two main prolog public verbs:
add_owner_approval/3 (UserList, InList, OutList) appends label('Owner-Approval', need(_)) to InList building OutList if UserList has no users contained in the defined owners of this path change.
In other words, the predicate just copies InList to OutList if at least one of the elements in UserList is an owner.
add_owner_approval/2 (InList, OutList) appends label('Owner-Approval', need(_)) to InList building OutList if no owners has given a Code-Review +2 to this path change.
This predicate is similar to the first one but generates a UserList with an hardcoded policy.
Since add_owner_approval/3 is not using hard coded policies, it can be suitable for complex customizations.
There is a second plugin, gerrit-owners-autoassign which depends on gerrit-owners. It will automatically assign all of the owners to review a change when it's created or updated.
This plugin is built with Bazel and two build modes are supported:
To build the plugin, issue the following command:
bazel build :all
The output is created in
bazel-genfiles/owners/owners.jar bazel-genfiles/owners-autoassign/owners-autoassign.jar
To execute the tests run:
bazel test //...
This project can be imported into the Eclipse IDE:
./tools/eclipse/project.sh
Create symbolic links of the owners and owners-autoassign folders and of the external_plugin_deps.bzl file to the Gerrit source code /plugins directory.
Create a symbolic link of the owners-common plugin to the Gerrit source code directory.
Then build the owners and owners-autoassign plugins with the usual Gerrit plugin compile command.
Example:
$ git clone https://gerrit.googlesource.com/plugins/owners $ git clone https://gerrit.googlesource.com/gerrit $ cd gerrit/plugins $ ln -s ../../owners/owners . $ ln -s ../../owners/owners-autoassign . $ ln -sf ../../owners/external_plugin_deps.bzl . $ cd .. $ ln -s ../owners/owners-common . $ bazel build plugins/owners plugins/owners-autoassign
NOTE: the owners-common folder is producing shared artifacts for the two plugins and does not need to be built separately being a direct dependency of the build process. Its resulting .jar must not be installed in gerrit plugins directory.
The output is created in
bazel-genfiles/plugins/owners/owners.jar bazel-genfiles/plugins/owners-autoassign/owners-autoassign.jar
To execute the tests run:
bazel test owners-common:test
This project can be imported into the Eclipse IDE:
Add the plugin name to the CUSTOM_PLUGINS in Gerrit core in tools/bzl/plugins.bzl file and run:
./tools/eclipse/project.py