tree 0b597ee415058e7e2524a6d70afab404e3934d98
parent d83fa90d3c3571b615c459cc5182c9cc915fbe13
author Luca Milanesio <luca.milanesio@gmail.com> 1781030485 +0100
committer Luca Milanesio <luca.milanesio@gmail.com> 1781682509 +0100

Remove PowerMock and replace with EasyMock

Remove PowerMock 2.0.9 (powermock-api-easymock, powermock-module-junit4
and their five transitive siblings) and the javassist version pin that
only existed to override PowerMock's older transitive. PowerMock 2.0.9
is the last release from 2020 and its classloader rewriting is
incompatible with EasyMock 5's MethodHandles.Lookup-based ByteBuddy
class injection on Java 17+: the generated proxy lands in
org.easymock.mocks.* but the Lookup is anchored at
org.easymock.internal.ClassProxyFactory and the JVM refuses the
cross-package define.

PowerMock's only feature this codebase used was mockStatic on
JgitWrapper. Convert JgitWrapper from static utility to a stateless
instance class so its method becomes invokevirtual on a mocked
instance, which plain EasyMock instance mocking handles. PathOwners
gains a package-private 11-arg constructor that accepts the wrapper
for tests; the public 10-arg overloads default to a real
new JgitWrapper(), so all production callers in plugins/owners are
unchanged.

Keeping a single mocking framework on the test classpath was preferred
over adopting Mockito.mockStatic on a still-static JgitWrapper.

Bump org.easymock:easymock to 5.6.0 for a byte-buddy that knows recent
JDK class-file versions.

Co-Authored-By: Daniele Sassoli <danielesassoli@gmail.com>
Change-Id: I5079628f6f3cde4786800e4810939e40b8a4ac48