tree 11f7639708fcb0f4514578ec4482fa8a5052dac6
parent 42bd33146977e837e0a33aa08dc759e0ef72fae1
author David Ostrovsky <david@ostrovsky.org> 1774170492 +0100
committer David Ostrovsky <david@ostrovsky.org> 1774252877 +0100

Discovery OAuth: Validate discovery config and add tests

Refactor the DiscoveryOAuthService to improve robustness and
maintainability.

* Validation:
  - Add validateRootUrl to ensure the configured root-url is valid and
    uses http/https.
  - Add validateDiscoveryDocument to verify that the provider's
    response contains all required OIDC endpoints (issuer, auth,
    token, and userinfo) and that they are absolute URLs.
  - Automatically trim trailing slashes from the root-url to prevent
    double-slashes in the final discovery path.
  - Add null-safety checks in DiscoveryApi.

* Performance:
  - Use Guava's CharStreams for more efficient stream-to-string
    conversion, replacing manual BufferedReader loops.

* Testing:
  - Add DiscoveryApiTest for unit testing the ScribeJava API bridge.
  - Add DiscoveryOAuthServiceTest with high coverage, including
    mocking the discovery process and testing various failure modes
    (malformed URLs, missing JSON fields, and HTTP errors).

Feature: https://github.com/davido/gerrit-oauth-provider/issues/134
Change-Id: I961c0a0e13511c4134e24a98c36e83aa12ea5c3c