| commit | be460ad82059349cc5fab827874620d79ed32435 | [log] [tgz] |
|---|---|---|
| author | Antonio Barone <syntonyze@gmail.com> | Thu Dec 16 17:14:28 2021 +0100 |
| committer | Antonio Barone <syntonyze@gmail.com> | Thu Dec 16 18:06:04 2021 +0100 |
| tree | a0beee69964700a122d145f53e42f9f2f32cd18b | |
| parent | 21590187df985fc9e129c15ef0816409f2d1a728 [diff] |
Fix exception when consuming index events of deleted changes When producing ChangeIndex events, the producing side does not set the name of the project in the event[1]. This is due to the `onChangeDeleted` interface, which can only provide the change Id and not the project name (see here [2]). This, in turn, causes the global-refdb library to throw an exception, when attempting to filter projects that the receiver is interested in consuming (see here[3]), since it cannot tell which project the event is associated to. The `ChangeIndexEvent` cannot be hydrated with the name of the project at production time, because the change has been deleted already, so attempts to lookup the project name would fail. The receiving side, on the other hand, can still find the deleted change in the index and thus recover the name of the project before asking the global-refdb to match the project name. [1] https://gerrit.googlesource.com/plugins/multi-site/+/refs/heads/master/src/main/java/com/googlesource/gerrit/plugins/multisite/index/IndexEventHandler.java#136 [2]https://gerrit.googlesource.com/gerrit/+/refs/heads/master/java/com/google/gerrit/extensions/events/ChangeIndexedListener.java#46 [3]https://review.gerrithub.io/plugins/gitiles/GerritForge/global-refdb/+/refs/heads/master/src/main/java/com/gerritforge/gerrit/globalrefdb/validation/ProjectsFilter.java#126 Bug: Issue 15433 Change-Id: I1914eb5b73e5cca5eedfbb47c433b2fc27583329
This plugin allows to deploy a distributed cluster of multiple Gerrit masters each using a separate site without sharing any storage. The alignment between the masters happens using the replication plugin and an external message broker.
Requirements for the Gerrit masters are:
NOTE: The multi-site plugin will not start if Gerrit is not yet migrated to NoteDb.
Supports multiple read/write masters across multiple sites across different geographic locations. The Gerrit nodes are kept synchronized between each other using the replication plugin and a global ref-database in order to detect and prevent split-brains.
For more details on the overall multi-site design and roadmap, please refer to the multi-site plugin DESIGN.md document
This plugin is released under the same Apache 2.0 license and copyright holders as of the Gerrit Code Review project.
The multi-site plugin can only be built in tree mode, by cloning Gerrit and the multi-site plugin code, and checking them out on the desired branch.
Example of cloning Gerrit and multi-site for a stable-2.16 build:
git clone -b stable-2.16 https://gerrit.googlesource.com/gerrit git clone -b stable-2.16 https://gerrit.googlesource.com/plugins/multi-site cd gerrit/plugins ln -s ../../multi-site . rm external_plugin_deps.bzl ln -s multi-site/external_plugin_deps.bzl .
Example of building the multi-site plugin:
cd gerrit bazel build plugins/multi-site
The multi-site.jar plugin is generated to bazel-bin/plugins/multi-site/multi-site.jar.
Example of testing the multi-site plugin:
cd gerrit bazel test plugins/multi-site:multi_site_tests
NOTE: The multi-site tests include also the use of Docker containers for instantiating and using a Kafka/Zookeeper broker. Make sure you have a Docker daemon running (/var/run/docker.sock accessible) or a DOCKER_HOST pointing to a Docker server.
Install the multi-site plugin into the $GERRIT_SITE/lib directory of all the Gerrit servers that are part of the multi-site cluster. Create a symbolic link from $GERRIT_SITE/lib/multi-site.jar into the $GERRIT_SITE/plugins.
Add the multi-site module to $GERRIT_SITE/etc/gerrit.config as follows:
[gerrit] installDbModule = com.googlesource.gerrit.plugins.multisite.GitModule installModule = com.googlesource.gerrit.plugins.multisite.Module
For more details on the configuration settings, please refer to the multi-site configuration documentation.
You also need to setup the Git-level replication between nodes, for more details please refer to the replication plugin documentation.
For information about available HTTP endpoints please refer to the documentation.