)]}'
{
  "commit": "d6a991399a264f7ddf0bc5e5a21dc3f7717b9e66",
  "tree": "b1d12f68de5cda1d9b9ced589996058427da8408",
  "parents": [
    "72defdd4de085398c797b0ab76017febebfdcb3a"
  ],
  "author": {
    "name": "Antoine Musso",
    "email": "hashar@free.fr",
    "time": "Thu May 06 21:54:01 2021 +0200"
  },
  "committer": {
    "name": "Christian Aistleitner",
    "email": "christian@quelltextlich.at",
    "time": "Mon May 10 07:26:44 2021 +0000"
  },
  "message": "Urlencode POST to conduit\n\nPhabricator API expects POST be urlencoded, much like when a browser\nsubmit a form (Content-Type: x-www-form-urlencoded) with the payload\nbeing urlencoded.\n\nAs an example, when doing a `maniphest.edit` to add a comment containing\n\u0027http://example.org/r/+/1234\u0027, the content is send as is but urldecoded\nby Phabricator which show with: \u0027http://example.org/r/ /1234\u0027, the \u0027+\u0027\nhas been decoded to a space.\n\nWe previously encountered the issue with commit message which we escapes\nin the soy template: ${escapedSubject|escapeUri} which is merely a\nworkaround. Some support request got send previously at:\nhttps://github.com/google/closure-templates/issues/152 which missed the\nlack of urlencoding in the POST.\n\nInstead of sending a StringEntity with \u0027param\u003d\u003cjson\u003e\u0027, use a\nUrlEncodedFormEntity which takes care of encoding. Soy templates can\nthen drop usage of `escapeUri`.\n\nBug: https://phabricator.wikimedia.org/T280197\nChange-Id: Icee02a62853817ecaa73403c44ce557634ecb07e\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "8eb695b30db350bd8972810280acdf9934e0751e",
      "old_mode": 33188,
      "old_path": "src/main/java/com/googlesource/gerrit/plugins/its/phabricator/conduit/ConduitConnection.java",
      "new_id": "585cd3b2267497e6b50817a924a3c8234b8d2852",
      "new_mode": 33188,
      "new_path": "src/main/java/com/googlesource/gerrit/plugins/its/phabricator/conduit/ConduitConnection.java"
    }
  ]
}