)]}'
{
  "commit": "be079f45d55e07287f2433bee1b888bb12ffe15e",
  "tree": "00a273f79045d5245decc275bdb26a762a767812",
  "parents": [
    "245448c0a74dd40e27028aee2b5af363fd7f3fcf"
  ],
  "author": {
    "name": "Hector Oswaldo Caballero",
    "email": "hector.caballero@ericsson.com",
    "time": "Mon Feb 19 21:12:44 2018 -0500"
  },
  "committer": {
    "name": "Hector Oswaldo Caballero",
    "email": "hector.caballero@ericsson.com",
    "time": "Mon Jun 04 17:52:09 2018 -0400"
  },
  "message": "Replace sets of Property by a simple map\n\nSo far, the information about an event was stored in a collection of\ncollections of properties. A Property was defined as a wrapper around a\nsimple pair of key -\u003e value entries. Even if simple as concept, this\ndata structure made the code unnecessarily complicated. For example, in\norder to get a value from the properties, it was needed to iterate over\nthe collection and compare the desired value with the property key. When\nthese properties were about to be used,  e.g. when adding a Soy comment,\nthis collection needed to be converted to a map in order to be used as\nthe context for the Soy renderer. In the tests, lots of mocking was done\naround the Property object which bloated and complicated the test code.\n\nUsing a simple map for storing the event information fulfills the same\ngoal but with some advantages: simpler loops, no need to iterate over\na collection to find and get some values, no need to convert to a map\nlater when the info is needed and, besides that, simplified tests.\n\nChange-Id: Id429d8cd9e626d88c1f81954e6b37488896f9b90\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "148874d74ce06c1ca4fbe99634d3cef3873da62b",
      "old_mode": 33188,
      "old_path": "src/main/java/com/googlesource/gerrit/plugins/its/base/ItsHookModule.java",
      "new_id": "530e45dfdb59daefe339c85c74c189edadcd34e2",
      "new_mode": 33188,
      "new_path": "src/main/java/com/googlesource/gerrit/plugins/its/base/ItsHookModule.java"
    },
    {
      "type": "modify",
      "old_id": "7ce208393e445fc72435e3d9053c0096037786f4",
      "old_mode": 33188,
      "old_path": "src/main/java/com/googlesource/gerrit/plugins/its/base/util/PropertyAttributeExtractor.java",
      "new_id": "6770a3c99d5f59fe07f7438483dcb1ec947b5243",
      "new_mode": 33188,
      "new_path": "src/main/java/com/googlesource/gerrit/plugins/its/base/util/PropertyAttributeExtractor.java"
    },
    {
      "type": "modify",
      "old_id": "85055e367f16a3f4d1a16e6f8b83332a0f014cff",
      "old_mode": 33188,
      "old_path": "src/main/java/com/googlesource/gerrit/plugins/its/base/util/PropertyExtractor.java",
      "new_id": "5fde1ab3bb59edf1a62e0786e04fe5563e91fb7d",
      "new_mode": 33188,
      "new_path": "src/main/java/com/googlesource/gerrit/plugins/its/base/util/PropertyExtractor.java"
    },
    {
      "type": "modify",
      "old_id": "7f73195a1af873844700188eb29bfe12bda75ba4",
      "old_mode": 33188,
      "old_path": "src/main/java/com/googlesource/gerrit/plugins/its/base/workflow/Action.java",
      "new_id": "10f362a98455bf08ee30af719b2286074335dc6e",
      "new_mode": 33188,
      "new_path": "src/main/java/com/googlesource/gerrit/plugins/its/base/workflow/Action.java"
    },
    {
      "type": "modify",
      "old_id": "844ac91ed663bff147576503cbd25f391113fe19",
      "old_mode": 33188,
      "old_path": "src/main/java/com/googlesource/gerrit/plugins/its/base/workflow/ActionController.java",
      "new_id": "3329610d1a7e9be09ec03b37a68c65a04a31edb7",
      "new_mode": 33188,
      "new_path": "src/main/java/com/googlesource/gerrit/plugins/its/base/workflow/ActionController.java"
    },
    {
      "type": "modify",
      "old_id": "3cc9afebfebf3db471ee49c2cf3c07a29dedc51f",
      "old_mode": 33188,
      "old_path": "src/main/java/com/googlesource/gerrit/plugins/its/base/workflow/ActionExecutor.java",
      "new_id": "726efac3dd84d88cc5f0058f4bc1308d7a99b6be",
      "new_mode": 33188,
      "new_path": "src/main/java/com/googlesource/gerrit/plugins/its/base/workflow/ActionExecutor.java"
    },
    {
      "type": "modify",
      "old_id": "6a64db2563c21af844dc7d684125bd4a49fd1199",
      "old_mode": 33188,
      "old_path": "src/main/java/com/googlesource/gerrit/plugins/its/base/workflow/AddComment.java",
      "new_id": "3f376f2567d6860d071ce7f7069fd074dca35fa7",
      "new_mode": 33188,
      "new_path": "src/main/java/com/googlesource/gerrit/plugins/its/base/workflow/AddComment.java"
    },
    {
      "type": "modify",
      "old_id": "1521092698aa96f25a19d73f9e16a4fe16c209d0",
      "old_mode": 33188,
      "old_path": "src/main/java/com/googlesource/gerrit/plugins/its/base/workflow/AddSoyComment.java",
      "new_id": "f1c19620183d524653b0d29e0d63be11b18fe5ff",
      "new_mode": 33188,
      "new_path": "src/main/java/com/googlesource/gerrit/plugins/its/base/workflow/AddSoyComment.java"
    },
    {
      "type": "modify",
      "old_id": "52c136934b8e76c63d3c5def3815ff583178223b",
      "old_mode": 33188,
      "old_path": "src/main/java/com/googlesource/gerrit/plugins/its/base/workflow/AddStandardComment.java",
      "new_id": "95b9c5e31c58db1e4208b6222b6f9df488a1c671",
      "new_mode": 33188,
      "new_path": "src/main/java/com/googlesource/gerrit/plugins/its/base/workflow/AddStandardComment.java"
    },
    {
      "type": "modify",
      "old_id": "7c06bb461b6c2a2e73522a26712b4b96243d2961",
      "old_mode": 33188,
      "old_path": "src/main/java/com/googlesource/gerrit/plugins/its/base/workflow/Condition.java",
      "new_id": "e5276527f17e38f25950e0d796073c1ccda3b5fd",
      "new_mode": 33188,
      "new_path": "src/main/java/com/googlesource/gerrit/plugins/its/base/workflow/Condition.java"
    },
    {
      "type": "modify",
      "old_id": "baf64b24a90c70cbca1eaca62e1270735cc8558c",
      "old_mode": 33188,
      "old_path": "src/main/java/com/googlesource/gerrit/plugins/its/base/workflow/LogEvent.java",
      "new_id": "5df562e100be48aceede60ae41d0bb069fddbdfc",
      "new_mode": 33188,
      "new_path": "src/main/java/com/googlesource/gerrit/plugins/its/base/workflow/LogEvent.java"
    },
    {
      "type": "delete",
      "old_id": "eb1f0872d4a1529da147ec83d92381c90852520d",
      "old_mode": 33188,
      "old_path": "src/main/java/com/googlesource/gerrit/plugins/its/base/workflow/Property.java",
      "new_id": "0000000000000000000000000000000000000000",
      "new_mode": 0,
      "new_path": "/dev/null"
    },
    {
      "type": "modify",
      "old_id": "3efa2699559ccecf69aef7717a069f7b99a6274c",
      "old_mode": 33188,
      "old_path": "src/main/java/com/googlesource/gerrit/plugins/its/base/workflow/Rule.java",
      "new_id": "b83b9699b8e3ef86846d1cc84da0e741bb3d66a9",
      "new_mode": 33188,
      "new_path": "src/main/java/com/googlesource/gerrit/plugins/its/base/workflow/Rule.java"
    },
    {
      "type": "modify",
      "old_id": "a6afa08f0b7aca090ed4555fe8d3a48f5656f8e3",
      "old_mode": 33188,
      "old_path": "src/main/java/com/googlesource/gerrit/plugins/its/base/workflow/RuleBase.java",
      "new_id": "fc705ad2e5c397958edce0b8bd32a734a2ae36f6",
      "new_mode": 33188,
      "new_path": "src/main/java/com/googlesource/gerrit/plugins/its/base/workflow/RuleBase.java"
    },
    {
      "type": "modify",
      "old_id": "b7e157a3e78ce7ed67f33da6a4eb0fb4ebe1dd24",
      "old_mode": 33188,
      "old_path": "src/test/java/com/googlesource/gerrit/plugins/its/base/util/PropertyAttributeExtractorTest.java",
      "new_id": "5339d6085811a7bf137bf25043f2669a2d928eb0",
      "new_mode": 33188,
      "new_path": "src/test/java/com/googlesource/gerrit/plugins/its/base/util/PropertyAttributeExtractorTest.java"
    },
    {
      "type": "modify",
      "old_id": "8ea6d7b7a9bf8f0b70135c741744833b69aa61c5",
      "old_mode": 33188,
      "old_path": "src/test/java/com/googlesource/gerrit/plugins/its/base/util/PropertyExtractorTest.java",
      "new_id": "249abcdafad8af88c951205a6a119792d86a8ae0",
      "new_mode": 33188,
      "new_path": "src/test/java/com/googlesource/gerrit/plugins/its/base/util/PropertyExtractorTest.java"
    },
    {
      "type": "modify",
      "old_id": "7c85f7f82adac36d95e8adfa7b680df58ffa825a",
      "old_mode": 33188,
      "old_path": "src/test/java/com/googlesource/gerrit/plugins/its/base/workflow/ActionControllerTest.java",
      "new_id": "4f8b4ef84be15036134377d6671c3e372b937e72",
      "new_mode": 33188,
      "new_path": "src/test/java/com/googlesource/gerrit/plugins/its/base/workflow/ActionControllerTest.java"
    },
    {
      "type": "modify",
      "old_id": "85173ab7ef45cdd367cfe005141ed22a95a7974c",
      "old_mode": 33188,
      "old_path": "src/test/java/com/googlesource/gerrit/plugins/its/base/workflow/ActionExecutorTest.java",
      "new_id": "be0c33a1c031d727db22aee5671e2be9b5b666e6",
      "new_mode": 33188,
      "new_path": "src/test/java/com/googlesource/gerrit/plugins/its/base/workflow/ActionExecutorTest.java"
    },
    {
      "type": "modify",
      "old_id": "19934064ffb67201efb88a5b923768635e8c6437",
      "old_mode": 33188,
      "old_path": "src/test/java/com/googlesource/gerrit/plugins/its/base/workflow/AddCommentTest.java",
      "new_id": "e11f8f268976464905a9141496630426bb2b2e41",
      "new_mode": 33188,
      "new_path": "src/test/java/com/googlesource/gerrit/plugins/its/base/workflow/AddCommentTest.java"
    },
    {
      "type": "modify",
      "old_id": "c26ea73ab69d197858ac7983c8a4aa5a4b922582",
      "old_mode": 33188,
      "old_path": "src/test/java/com/googlesource/gerrit/plugins/its/base/workflow/AddStandardCommentTest.java",
      "new_id": "8b21c1d321414b69f47fe5d3ca8b9e0e3d9d0c3e",
      "new_mode": 33188,
      "new_path": "src/test/java/com/googlesource/gerrit/plugins/its/base/workflow/AddStandardCommentTest.java"
    },
    {
      "type": "modify",
      "old_id": "c1a6a8d46bbc15fd78dc4fe9a587f2dd97e6e5d8",
      "old_mode": 33188,
      "old_path": "src/test/java/com/googlesource/gerrit/plugins/its/base/workflow/ConditionTest.java",
      "new_id": "3df38cc9d9bbe22ee04e8e0f81d2f87830d142eb",
      "new_mode": 33188,
      "new_path": "src/test/java/com/googlesource/gerrit/plugins/its/base/workflow/ConditionTest.java"
    },
    {
      "type": "modify",
      "old_id": "e9a087225845b535acf118a992bed78a19f5075f",
      "old_mode": 33188,
      "old_path": "src/test/java/com/googlesource/gerrit/plugins/its/base/workflow/LogEventTest.java",
      "new_id": "c97c5925f14ec2f1efd16b3410905b45606dbd0c",
      "new_mode": 33188,
      "new_path": "src/test/java/com/googlesource/gerrit/plugins/its/base/workflow/LogEventTest.java"
    },
    {
      "type": "delete",
      "old_id": "06ac41a132d121116ed6cdec514015303848c232",
      "old_mode": 33188,
      "old_path": "src/test/java/com/googlesource/gerrit/plugins/its/base/workflow/PropertyTest.java",
      "new_id": "0000000000000000000000000000000000000000",
      "new_mode": 0,
      "new_path": "/dev/null"
    },
    {
      "type": "modify",
      "old_id": "d7c66b250812b0ccfc5b2c64c9a28460f28344b8",
      "old_mode": 33188,
      "old_path": "src/test/java/com/googlesource/gerrit/plugins/its/base/workflow/RuleBaseTest.java",
      "new_id": "1002a925959f2dd75ccb93c3ea3c23bb438b88de",
      "new_mode": 33188,
      "new_path": "src/test/java/com/googlesource/gerrit/plugins/its/base/workflow/RuleBaseTest.java"
    },
    {
      "type": "modify",
      "old_id": "6d4d234905e0edd7b62825574c5dab1d90aa06e3",
      "old_mode": 33188,
      "old_path": "src/test/java/com/googlesource/gerrit/plugins/its/base/workflow/RuleTest.java",
      "new_id": "c106a81bb4a92d678ae041a8f0e46b9d1797bd79",
      "new_mode": 33188,
      "new_path": "src/test/java/com/googlesource/gerrit/plugins/its/base/workflow/RuleTest.java"
    }
  ]
}