tree fd490a862a645b6c32e321ba6d9215d895816b70
parent 0db87721314c2c5f05f68bf59fe26333c25c16bd
author Sasa Zivkov <sasa.zivkov@sap.com> 1785340327 +0200
committer Sasa Zivkov <sasa.zivkov@sap.com> 1785920639 +0200
change-id vsqmyqunwnrrzkvswrzqqsylynorsvqr

ForwardedIndexChangeHandler: check SHA visibility before reindexing

Move the isChangeUpToDate() check before reindexIfStale() so that
staleness is detected upfront. Previously, reindexIfStale() was called
unconditionally and isChangeUpToDate() served as a post-condition: if
the JGit cache happened to refresh between the two calls, the post-check
would pass and we would accept a result where no actual reindexing took
place.

With this change, if the meta SHA is not yet visible, indexOnce()
returns false immediately and we proceed with the next (re)try.
reindexIfStale() is only called once the SHA is confirmed visible,
making the retry logic effective.

Bug: Issue 541924680
Change-Id: If546dbacbfc9635a5ae9ac10ec5848486ce5cd4c