tree cc15591519146894a51032a0a44b82465e54f408
parent 03bcbc7b9e3ae9eaac5f11a67941538f329998e2
author David Ostrovsky <david@ostrovsky.org> 1608235260 +0100
committer David Ostrovsky <david@ostrovsky.org> 1608242652 +0100

Align Project.NameKey serialization to gerrit core

Since I96dbb4c38f2 Project.NameKey is serialized in stream events as:

  "project": "project-name"

However high-availability plugin missed this feature and doesn't use
custom JsonSerializer, so that the Project.NameKey is serialized in
legacy form:

  "project": { "name" : "project-name" }

Starting from gerrit release 3.1 this plugin migrated to custom
ProjectNameKeyAdapter that was added in I242b51530a3. As a side effect,
project name serialization was implicitly changed to new serialization
form.

This incompatibility can cause a problem in zero-downtime upgrade
scenario, where the events created by gerrit 3.0 cannot be de-serialized
by second node running gerrit 3.1.

To rectify, install custom ProjectNameKeyAdapter, that is aware of skew
of project name representation and could also understand legacy and new
form of project name.

Note, that the plugin own ProjectNameKeyAdapter class should be removed
when this change is merged to stable-3.1 branch. The test class could be
removed as well, because similar round trip serialization tests exist
in gerrit core.

Bug: Issue 13825
Change-Id: I73bd4df898d8b978f67e9ab27fe5bb5461a951fd