FileBasedWebSessionCacheCleaner: Make CleanupTask a static inner class
I'm not sure what the reason was for defining the CleanupTask
class as a separate class outside of the main class in the file,
but it's unusual to do this rather than making it a static inner
class.
Reported-By: Martin Fick <mfick@codeaurora.org>
Change-Id: I975368fb20533a62eb8fe936a8c345371ea11f3b
diff --git a/src/main/java/com/ericsson/gerrit/plugins/highavailability/websession/file/FileBasedWebSessionCacheCleaner.java b/src/main/java/com/ericsson/gerrit/plugins/highavailability/websession/file/FileBasedWebSessionCacheCleaner.java
index 14134e2..b9dc245 100644
--- a/src/main/java/com/ericsson/gerrit/plugins/highavailability/websession/file/FileBasedWebSessionCacheCleaner.java
+++ b/src/main/java/com/ericsson/gerrit/plugins/highavailability/websession/file/FileBasedWebSessionCacheCleaner.java
@@ -36,6 +36,30 @@
private final long cleanupIntervalMillis;
private ScheduledFuture<?> scheduledCleanupTask;
+ static class CleanupTask implements Runnable {
+ private static final Logger log = LoggerFactory.getLogger(CleanupTask.class);
+ private final FileBasedWebsessionCache fileBasedWebSessionCache;
+ private final String pluginName;
+
+ @Inject
+ CleanupTask(FileBasedWebsessionCache fileBasedWebSessionCache, @PluginName String pluginName) {
+ this.fileBasedWebSessionCache = fileBasedWebSessionCache;
+ this.pluginName = pluginName;
+ }
+
+ @Override
+ public void run() {
+ log.info("Cleaning up expired file based websessions...");
+ fileBasedWebSessionCache.cleanUp();
+ log.info("Cleaning up expired file based websessions...Done");
+ }
+
+ @Override
+ public String toString() {
+ return String.format("[%s] Clean up expired file based websessions", pluginName);
+ }
+ }
+
@Inject
FileBasedWebSessionCacheCleaner(
WorkQueue queue, Provider<CleanupTask> cleanupTaskProvider, Configuration config) {
@@ -64,27 +88,3 @@
}
}
}
-
-class CleanupTask implements Runnable {
- private static final Logger log = LoggerFactory.getLogger(CleanupTask.class);
- private final FileBasedWebsessionCache fileBasedWebSessionCache;
- private final String pluginName;
-
- @Inject
- CleanupTask(FileBasedWebsessionCache fileBasedWebSessionCache, @PluginName String pluginName) {
- this.fileBasedWebSessionCache = fileBasedWebSessionCache;
- this.pluginName = pluginName;
- }
-
- @Override
- public void run() {
- log.info("Cleaning up expired file based websessions...");
- fileBasedWebSessionCache.cleanUp();
- log.info("Cleaning up expired file based websessions...Done");
- }
-
- @Override
- public String toString() {
- return String.format("[%s] Clean up expired file based websessions", pluginName);
- }
-}
diff --git a/src/test/java/com/ericsson/gerrit/plugins/highavailability/websession/file/FileBasedWebSessionCacheCleanerTest.java b/src/test/java/com/ericsson/gerrit/plugins/highavailability/websession/file/FileBasedWebSessionCacheCleanerTest.java
index b3b8ac1..45ac4b7 100644
--- a/src/test/java/com/ericsson/gerrit/plugins/highavailability/websession/file/FileBasedWebSessionCacheCleanerTest.java
+++ b/src/test/java/com/ericsson/gerrit/plugins/highavailability/websession/file/FileBasedWebSessionCacheCleanerTest.java
@@ -25,6 +25,7 @@
import static org.mockito.Mockito.when;
import com.ericsson.gerrit.plugins.highavailability.Configuration;
+import com.ericsson.gerrit.plugins.highavailability.websession.file.FileBasedWebSessionCacheCleaner.CleanupTask;
import com.google.gerrit.server.git.WorkQueue;
import com.google.gerrit.server.git.WorkQueue.Executor;
import com.google.inject.Provider;