tree 0e372d50da624886357d94dd4edc9f7deae4349f
parent 89dec3e3c2fd7dbdd55afc465838cef148a0d32f
author Luca Milanesio <luca.milanesio@gmail.com> 1625258964 +0100
committer Luca Milanesio <luca.milanesio@gmail.com> 1625259210 +0100

Fix BlockedThreadsCheck failing with un-blocked threads

The introduction of BlockedThreadsCheck introduced a P0
regression because of the accumulatio of the counter of
blocked threads caused any Gerrit instance to eventually
fail once the counter of blocked threads reached the 50%
of the total number.

Remove the @Singleton annotation misplaced on the check
and make sure that similar issues aren't passed unnoticed
by using the actual Guice injection for creating the
BlockedThreadsCheck in tests rather than calling the
constructor directly.

Bug: Issue 14736
Change-Id: I430a7a576f8c41594c59d71cced6d43d7acf985a