)]}'
{
  "commit": "31d1fc8a71d3f843db0a2ba29bbb8d043aa7d21a",
  "tree": "31fcf3ca4500f7ebf09029a618148de09acdae0f",
  "parents": [
    "188140328dbf1a98159b6531b7fad77df32490fe"
  ],
  "author": {
    "name": "Fabio Ponciroli",
    "email": "ponch78@gmail.com",
    "time": "Wed Apr 14 15:18:39 2021 +0200"
  },
  "committer": {
    "name": "Fabio Ponciroli",
    "email": "ponch78@gmail.com",
    "time": "Wed Apr 21 12:48:25 2021 +0200"
  },
  "message": "Plugin reports wrong number of failures\n\nThe increment of the metric failure should happen\n*when* a new failure is happening and NOT when the metric\nis read from a callback.\n\nThe metrics are now published as soon as a single check is performed,\ni.e.: a doCheck() for a *Check class runs.\nThe metric collector system will just scrape them when needed without\nretriggering any calculation of the metrics.\n\nThe metrics are now injected in the AbstractHealthCheck, which\ntakes care of updating them whenever a check runs.\n\nAs part of this change the latency is now represented as a Timer, rather\nthan a Gauge as it was wrongly done before.\n\nBug: Issue 14385\nChange-Id: I5f149f6893289c2874d125a9c04862d53cacd19b\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "cea25300f49b01248d1e5723d43add5c005ac770",
      "old_mode": 33188,
      "old_path": "src/main/java/com/googlesource/gerrit/plugins/healthcheck/HealthCheckMetrics.java",
      "new_id": "1f88020c0ac8f860618e53f200c4411f4f171488",
      "new_mode": 33188,
      "new_path": "src/main/java/com/googlesource/gerrit/plugins/healthcheck/HealthCheckMetrics.java"
    },
    {
      "type": "modify",
      "old_id": "6ff3d0490cde1b8441406aec7fbb9a344dd6a1ee",
      "old_mode": 33188,
      "old_path": "src/main/java/com/googlesource/gerrit/plugins/healthcheck/HealthCheckSubsystemsModule.java",
      "new_id": "304a40c1140e1caca2da2707d225eab05fa64a85",
      "new_mode": 33188,
      "new_path": "src/main/java/com/googlesource/gerrit/plugins/healthcheck/HealthCheckSubsystemsModule.java"
    },
    {
      "type": "modify",
      "old_id": "d0181ab8d24a8583c20e86c5952a0328504c717d",
      "old_mode": 33188,
      "old_path": "src/main/java/com/googlesource/gerrit/plugins/healthcheck/check/AbstractHealthCheck.java",
      "new_id": "9e4544ad5796aaa072754349126a821798ef0b16",
      "new_mode": 33188,
      "new_path": "src/main/java/com/googlesource/gerrit/plugins/healthcheck/check/AbstractHealthCheck.java"
    },
    {
      "type": "modify",
      "old_id": "f3afc99451ed42b6c523d49bff7c29cc56ce87b4",
      "old_mode": 33188,
      "old_path": "src/main/java/com/googlesource/gerrit/plugins/healthcheck/check/ActiveWorkersCheck.java",
      "new_id": "dcf2f0ed61430b633ed9aeec481fe465b0e0f73c",
      "new_mode": 33188,
      "new_path": "src/main/java/com/googlesource/gerrit/plugins/healthcheck/check/ActiveWorkersCheck.java"
    },
    {
      "type": "modify",
      "old_id": "f00b155167d13c69d7f3b2a5646e22394aa4197f",
      "old_mode": 33188,
      "old_path": "src/main/java/com/googlesource/gerrit/plugins/healthcheck/check/AuthHealthCheck.java",
      "new_id": "cd0274d29a36d20341ad48472af24867d435504c",
      "new_mode": 33188,
      "new_path": "src/main/java/com/googlesource/gerrit/plugins/healthcheck/check/AuthHealthCheck.java"
    },
    {
      "type": "modify",
      "old_id": "db5e83a6c86c040c61238d1a07115cfa8f956c05",
      "old_mode": 33188,
      "old_path": "src/main/java/com/googlesource/gerrit/plugins/healthcheck/check/DeadlockCheck.java",
      "new_id": "a368246fec51e695e93b7d05280b66678b75e5b8",
      "new_mode": 33188,
      "new_path": "src/main/java/com/googlesource/gerrit/plugins/healthcheck/check/DeadlockCheck.java"
    },
    {
      "type": "modify",
      "old_id": "c464a9e016537da5dc2c9b48c746a3ce1c299337",
      "old_mode": 33188,
      "old_path": "src/main/java/com/googlesource/gerrit/plugins/healthcheck/check/GlobalHealthCheck.java",
      "new_id": "b004eaafa76f351408414cbad46ae3756b16fe58",
      "new_mode": 33188,
      "new_path": "src/main/java/com/googlesource/gerrit/plugins/healthcheck/check/GlobalHealthCheck.java"
    },
    {
      "type": "modify",
      "old_id": "46acdde3bfa627fd805e3c6031ab2f2e6af7eb92",
      "old_mode": 33188,
      "old_path": "src/main/java/com/googlesource/gerrit/plugins/healthcheck/check/HealthCheck.java",
      "new_id": "7c4f8a1c6fccf0f0299288f5fde28c62b2f0291b",
      "new_mode": 33188,
      "new_path": "src/main/java/com/googlesource/gerrit/plugins/healthcheck/check/HealthCheck.java"
    },
    {
      "type": "modify",
      "old_id": "ac4ba51a8a2a6f5d669ce209215dc85c6a24c619",
      "old_mode": 33188,
      "old_path": "src/main/java/com/googlesource/gerrit/plugins/healthcheck/check/HealthCheckNames.java",
      "new_id": "97e06d01289387ee21fc36d42b13be85b8df94e5",
      "new_mode": 33188,
      "new_path": "src/main/java/com/googlesource/gerrit/plugins/healthcheck/check/HealthCheckNames.java"
    },
    {
      "type": "modify",
      "old_id": "9c6930ff34d508c662a854e8536ae0d1b4edf29b",
      "old_mode": 33188,
      "old_path": "src/main/java/com/googlesource/gerrit/plugins/healthcheck/check/JGitHealthCheck.java",
      "new_id": "d107588e65399f27091d171363a95d7631a60dff",
      "new_mode": 33188,
      "new_path": "src/main/java/com/googlesource/gerrit/plugins/healthcheck/check/JGitHealthCheck.java"
    },
    {
      "type": "modify",
      "old_id": "4da142dfde4004e361c5b650cc09e31f3da93e3e",
      "old_mode": 33188,
      "old_path": "src/main/java/com/googlesource/gerrit/plugins/healthcheck/check/ProjectsListHealthCheck.java",
      "new_id": "9850a104a505839b849e842bfa275e230c14f8e2",
      "new_mode": 33188,
      "new_path": "src/main/java/com/googlesource/gerrit/plugins/healthcheck/check/ProjectsListHealthCheck.java"
    },
    {
      "type": "modify",
      "old_id": "5ccaf9b4730e8a420bc56ed1cb265d64d9796180",
      "old_mode": 33188,
      "old_path": "src/main/java/com/googlesource/gerrit/plugins/healthcheck/check/QueryChangesHealthCheck.java",
      "new_id": "9b6825f53855b7964762501c902179de48174bd7",
      "new_mode": 33188,
      "new_path": "src/main/java/com/googlesource/gerrit/plugins/healthcheck/check/QueryChangesHealthCheck.java"
    },
    {
      "type": "add",
      "old_id": "0000000000000000000000000000000000000000",
      "old_mode": 0,
      "old_path": "/dev/null",
      "new_id": "f67802eddf8d990f0226cf5f1b8a7c3f5f940ac3",
      "new_mode": 33188,
      "new_path": "src/test/java/com/googlesource/gerrit/plugins/healthcheck/AbstractHealthCheckTest.java"
    },
    {
      "type": "modify",
      "old_id": "71bef4393a884f6cc80b82c6450f668e8682434a",
      "old_mode": 33188,
      "old_path": "src/test/java/com/googlesource/gerrit/plugins/healthcheck/ActiveWorkersCheckTest.java",
      "new_id": "df88c4811a7a7f31c5c4fc7eee00f302db0cfd0d",
      "new_mode": 33188,
      "new_path": "src/test/java/com/googlesource/gerrit/plugins/healthcheck/ActiveWorkersCheckTest.java"
    },
    {
      "type": "modify",
      "old_id": "d53a1d831e5116dd6db3ee67a05b99b162079133",
      "old_mode": 33188,
      "old_path": "src/test/java/com/googlesource/gerrit/plugins/healthcheck/DeadlockCheckTest.java",
      "new_id": "79a4bc42ff5efb2dc5b244861186c6346069882a",
      "new_mode": 33188,
      "new_path": "src/test/java/com/googlesource/gerrit/plugins/healthcheck/DeadlockCheckTest.java"
    },
    {
      "type": "add",
      "old_id": "0000000000000000000000000000000000000000",
      "old_mode": 0,
      "old_path": "/dev/null",
      "new_id": "7523e95b37ba37257c069c2f88cb184a9f639623",
      "new_mode": 33188,
      "new_path": "src/test/java/com/googlesource/gerrit/plugins/healthcheck/DummyHealthCheckMetricsFactory.java"
    },
    {
      "type": "modify",
      "old_id": "1c01950edfed6d685a6fc6a894c56e69272957b2",
      "old_mode": 33188,
      "old_path": "src/test/java/com/googlesource/gerrit/plugins/healthcheck/HealthCheckMetricsTest.java",
      "new_id": "b1866582ad2eb715ac0a447c909979f0bb3aee6e",
      "new_mode": 33188,
      "new_path": "src/test/java/com/googlesource/gerrit/plugins/healthcheck/HealthCheckMetricsTest.java"
    },
    {
      "type": "modify",
      "old_id": "78b89e4326252bd3afcb09e98d998dd82fb2ffc2",
      "old_mode": 33188,
      "old_path": "src/test/java/com/googlesource/gerrit/plugins/healthcheck/HealthCheckStatusEndpointTest.java",
      "new_id": "b2fb862e6677342be52fe30a040f767172af0bc6",
      "new_mode": 33188,
      "new_path": "src/test/java/com/googlesource/gerrit/plugins/healthcheck/HealthCheckStatusEndpointTest.java"
    },
    {
      "type": "modify",
      "old_id": "74956c6182e5a7992ce144d4d819fcf3b4f9a97e",
      "old_mode": 33188,
      "old_path": "src/test/java/com/googlesource/gerrit/plugins/healthcheck/JGitHealthCheckTest.java",
      "new_id": "3c0adaea2c54447fff8de5de781fafbeb6b22474",
      "new_mode": 33188,
      "new_path": "src/test/java/com/googlesource/gerrit/plugins/healthcheck/JGitHealthCheckTest.java"
    },
    {
      "type": "modify",
      "old_id": "2ab0d836f1a72f728bc52f8b5f451bf97e1f7397",
      "old_mode": 33188,
      "old_path": "src/test/java/com/googlesource/gerrit/plugins/healthcheck/ProjectsListHealthCheckTest.java",
      "new_id": "c8d25b643a15e280ab471ab30df3c2981ba9e66c",
      "new_mode": 33188,
      "new_path": "src/test/java/com/googlesource/gerrit/plugins/healthcheck/ProjectsListHealthCheckTest.java"
    }
  ]
}