Merge branch 'stable-2.16' into stable-3.0

* stable-2.16:
  Bazel: Fix lint warning flagged by buildifier
  Make transitive starlark loads explicit
  Make transitive starlark loads explicit
  Make transitive starlark loads explicit

Change-Id: I3cf52e6bb276d7bfeaca95648de41f5f80f7d92b
diff --git a/BUILD b/BUILD
index 394861c..96f208c 100644
--- a/BUILD
+++ b/BUILD
@@ -1,25 +1,6 @@
+load("//tools/bzl:genrule2.bzl", "genrule2")
 load("//tools/bzl:plugin.bzl", "gerrit_plugin")
 
-genrule(
-    name = "gitiles",
-    srcs = [
-        ":gitiles__base",
-        "@gitiles-servlet//jar",
-    ],
-    outs = ["gitiles.jar"],
-    cmd = " && ".join([
-        "ROOT=$$PWD",
-        "TMP=$$(mktemp -d || mktemp -d -t bazel-tmp)",
-        "cp $(location :gitiles__base) $@",
-        "chmod +w $@",
-        "unzip -qd $$TMP $(location @gitiles-servlet//jar) \"com/google/gitiles/static/*\"",
-        "cd $$TMP/com/google/gitiles",
-        "mv static +static",
-        "zip -Drq $$ROOT/$@ -g . -i \"+static/*\"",
-    ]),
-    visibility = ["//plugins:__subpackages__"],
-)
-
 gerrit_plugin(
     name = "gitiles",
     srcs = glob(["src/main/java/**/*.java"]),
@@ -33,11 +14,23 @@
         "Gerrit-HttpStaticPrefix: +static",
         "Gerrit-HttpDocumentationPrefix: +Documentation",
     ],
+    resource_jars = [":gitiles-servlet-resources"],
     resources = glob(["src/main/resources/**/*"]),
-    target_suffix = "__base",
     deps = ["//lib/gitiles"],
 )
 
+genrule2(
+    name = "gitiles-servlet-resources",
+    srcs = ["@gitiles-servlet//jar"],
+    outs = ["gitiles-servlet-resources.jar"],
+    cmd = " && ".join([
+        "unzip -qd $$TMP $(location @gitiles-servlet//jar) \"com/google/gitiles/static/*\"",
+        "cd $$TMP/com/google/gitiles",
+        "mv static +static",
+        "zip -qr $$ROOT/$@ .",
+    ]),
+)
+
 java_library(
     name = "gitiles__classpath_deps",
     testonly = 1,