)]}' { "commit": "fb54c79cb4acb1984cd1f8b1e317553aa8ba79c0", "tree": "6ff657a664a1e71baf6419ea1c2711125d2bc1d2", "parents": [ "d25f6f0f8244bcd436ad6649ff0bb0230acca43d" ], "author": { "name": "Luca Milanesio", "email": "luca.milanesio@gmail.com", "time": "Fri Feb 20 08:56:12 2015 +0000" }, "committer": { "name": "Luca Milanesio", "email": "luca.milanesio@gmail.com", "time": "Sun Mar 08 11:28:43 2015 +0000" }, "message": "Improvements of feedback from review I86fb8fab3\n\nGitHub authentication has been submitted 9 months ago to Gerrit as\nextra authentication backend: a lot of suggestions and after 57 (!)\npatch-sets many improvements have been added to the code and are now\nincorporated into GitHub master:\n\n- Introduction of random state to prevent OAuth code injection and\n replay attacks\n- Upgrade to HTTPClient 4.4 and connection pooling\n- Introduction of HTTP proxy for outbound connections when installed\n within company firewalls\n- Removal of heavy non serialisable objects from the HTTP Session\n- Early release of HTTP connections to the pool to improve scalability\n- Simplified set-up during init\n- Improved documentation\n\nMany thanks to all the people that participated in the Code-Review and\ncontributions: as Git doesn’t allow to have more than one author,\nI will mention them below.\n\nThanks to: Edwin Kempin, David Pursehouse, Thomas Broyer,\n David Ostrovsky, Sasa Zivkov, Andre Saddler, Dariusz Luksza,\n Derek Hunter, Will DeBerry, Tom Hughes, Shawn Pearce\n\nChange-Id: I19e761485692d9b4bc0ade8d0f3ad761b0fa5369\n", "tree_diff": [ { "type": "modify", "old_id": "c0ab78fc101951d6f13d4315f3d28aa6dca72f2e", "old_mode": 33188, "old_path": "github-oauth/pom.xml", "new_id": "e6d70e7b22f06aa0a910db947ec9ac719ca975a3", "new_mode": 33188, "new_path": "github-oauth/pom.xml" }, { "type": "delete", "old_id": "367a3905719b06bd9f06744e35bc01ad822fe32e", "old_mode": 33188, "old_path": "github-oauth/src/main/java/com/googlesource/gerrit/plugins/github/oauth/GitHubHttpProvider.java", "new_id": "0000000000000000000000000000000000000000", "new_mode": 0, "new_path": "/dev/null" }, { "type": "modify", "old_id": "295099615ba208b21e3dc3d1cb9ab030ae665d94", "old_mode": 33188, "old_path": "github-oauth/src/main/java/com/googlesource/gerrit/plugins/github/oauth/GitHubLogin.java", "new_id": "32f751a5a29ae4d7b94c9bfd7f2372c77f6f2540", "new_mode": 33188, "new_path": "github-oauth/src/main/java/com/googlesource/gerrit/plugins/github/oauth/GitHubLogin.java" }, { "type": "modify", "old_id": "c41be2640f37761c7eb798bf17c896cd3403f730", "old_mode": 33188, "old_path": "github-oauth/src/main/java/com/googlesource/gerrit/plugins/github/oauth/GitHubOAuthConfig.java", "new_id": "7d30d1950e08ee76b5d60201270a6d31b1bceb9e", "new_mode": 33188, "new_path": "github-oauth/src/main/java/com/googlesource/gerrit/plugins/github/oauth/GitHubOAuthConfig.java" }, { "type": "modify", "old_id": "29d8840c88c6ffa65696b6ecbad44a1e8ca214a0", "old_mode": 33188, "old_path": "github-oauth/src/main/java/com/googlesource/gerrit/plugins/github/oauth/IdentifiedUserGitHubLoginProvider.java", "new_id": "646b60277d887afef3551b480e9ff8511059d722", "new_mode": 33188, "new_path": "github-oauth/src/main/java/com/googlesource/gerrit/plugins/github/oauth/IdentifiedUserGitHubLoginProvider.java" }, { "type": "modify", "old_id": "e2a8f26e4abacc4e6a923fe66d71b83c17c02032", "old_mode": 33188, "old_path": "github-oauth/src/main/java/com/googlesource/gerrit/plugins/github/oauth/OAuthGitFilter.java", "new_id": "c0f3897631224c843071f82d27fd510ccd9f7841", "new_mode": 33188, "new_path": "github-oauth/src/main/java/com/googlesource/gerrit/plugins/github/oauth/OAuthGitFilter.java" }, { "type": "modify", "old_id": "563a71ee926a5161dd2b5129065e13c7af7d26e6", "old_mode": 33188, "old_path": "github-oauth/src/main/java/com/googlesource/gerrit/plugins/github/oauth/OAuthProtocol.java", "new_id": "4358c0df1976fef18f6ab2faa0255af828e26d1e", "new_mode": 33188, "new_path": "github-oauth/src/main/java/com/googlesource/gerrit/plugins/github/oauth/OAuthProtocol.java" }, { "type": "modify", "old_id": "bf0a4b172a437073a0173896ac1722a25af3df9c", "old_mode": 33188, "old_path": "github-oauth/src/main/java/com/googlesource/gerrit/plugins/github/oauth/OAuthWebFilter.java", "new_id": "6929d16080b5dd6a22ecd3f2c0418626d9efef70", "new_mode": 33188, "new_path": "github-oauth/src/main/java/com/googlesource/gerrit/plugins/github/oauth/OAuthWebFilter.java" }, { "type": "add", "old_id": "0000000000000000000000000000000000000000", "old_mode": 0, "old_path": "/dev/null", "new_id": "02638775a9e431f17e866f97ab8b630781c66ce3", "new_mode": 33188, "new_path": "github-oauth/src/main/java/com/googlesource/gerrit/plugins/github/oauth/PooledHttpClientProvider.java" }, { "type": "modify", "old_id": "fcf52a58acbb98f905d377b757afcc47fb9f2f26", "old_mode": 33188, "old_path": "github-plugin/pom.xml", "new_id": "259f5598f59a387c643686a6f3c72a73486ac46f", "new_mode": 33188, "new_path": "github-plugin/pom.xml" }, { "type": "modify", "old_id": "f4d070d88cde836ff0514eba1c5dc6e505259406", "old_mode": 33188, "old_path": "github-plugin/src/main/java/com/googlesource/gerrit/plugins/github/GitHubConfig.java", "new_id": "17c3b9e0cd4858bbd3fa65654d7b3c3ecd30046d", "new_mode": 33188, "new_path": "github-plugin/src/main/java/com/googlesource/gerrit/plugins/github/GitHubConfig.java" }, { "type": "modify", "old_id": "29727a420340afa322b132b0e1f0cbb68993d01b", "old_mode": 33188, "old_path": "github-plugin/src/main/java/com/googlesource/gerrit/plugins/github/GuiceHttpModule.java", "new_id": "6bfbb16eefc2f8b45b814e3d4e94e2e3514680bb", "new_mode": 33188, "new_path": "github-plugin/src/main/java/com/googlesource/gerrit/plugins/github/GuiceHttpModule.java" }, { "type": "modify", "old_id": "261587f6aebafa70bb7543f10f37dc0bac62cbe2", "old_mode": 33188, "old_path": "github-plugin/src/main/java/com/googlesource/gerrit/plugins/github/InitGitHub.java", "new_id": "564fd3ea8b210ab6d3128988304ac30b1d3b9438", "new_mode": 33188, "new_path": "github-plugin/src/main/java/com/googlesource/gerrit/plugins/github/InitGitHub.java" }, { "type": "modify", "old_id": "b844ecca91d3818997087fbd68f762233d8227c4", "old_mode": 33188, "old_path": "github-plugin/src/main/java/com/googlesource/gerrit/plugins/github/filters/GitHubOAuthFilter.java", "new_id": "59ceb464df3a3110144cf74d98c2a88d6bfd77a7", "new_mode": 33188, "new_path": "github-plugin/src/main/java/com/googlesource/gerrit/plugins/github/filters/GitHubOAuthFilter.java" }, { "type": "modify", "old_id": "8e4f57e30b157dce23666b4d0087043e72c9e7cf", "old_mode": 33188, "old_path": "github-plugin/src/main/java/com/googlesource/gerrit/plugins/github/git/GitHubRepository.java", "new_id": "c5cf07a41fe829622421620b64e5524f9a8454d4", "new_mode": 33188, "new_path": "github-plugin/src/main/java/com/googlesource/gerrit/plugins/github/git/GitHubRepository.java" }, { "type": "modify", "old_id": "44e5a236adac849f337c108b8538dc3f17f2d531", "old_mode": 33188, "old_path": "github-plugin/src/main/java/com/googlesource/gerrit/plugins/github/git/ReplicateProjectStep.java", "new_id": "5410c78189a98551aae415cf41c72c889d9d4dc6", "new_mode": 33188, "new_path": "github-plugin/src/main/java/com/googlesource/gerrit/plugins/github/git/ReplicateProjectStep.java" }, { "type": "modify", "old_id": "b9f5d34cf827f4514ca6f47d05cf60def7d7d4fe", "old_mode": 33188, "old_path": "github-plugin/src/main/java/com/googlesource/gerrit/plugins/github/velocity/VelocityViewServlet.java", "new_id": "cd1a2027691207e0f57bd67c63af681970c1435d", "new_mode": 33188, "new_path": "github-plugin/src/main/java/com/googlesource/gerrit/plugins/github/velocity/VelocityViewServlet.java" }, { "type": "add", "old_id": "0000000000000000000000000000000000000000", "old_mode": 0, "old_path": "/dev/null", "new_id": "5ba04a6f7f4f445bb2fbe65257a40485ac7e7595", "new_mode": 33188, "new_path": "github-plugin/src/main/resources/Documentation/about.md" }, { "type": "modify", "old_id": "2d1894466d54cca91dac9ef2b886b15bd195ca8c", "old_mode": 33188, "old_path": "github-plugin/src/main/resources/Documentation/config.md", "new_id": "9d7c87bcbc0babc618082df21af395599db29912", "new_mode": 33188, "new_path": "github-plugin/src/main/resources/Documentation/config.md" } ] }