commit 945680bdef994f234aba5cca21eed7939d1f128a
author Fabio Ponciroli <ponch78@gmail.com> Mon Oct 10 07:45:34 2022 +0000
committer Gerrit Code Review <noreply-gerritcodereview@google.com> Mon Oct 10 07:45:34 2022 +0000
tree 21115a4a8db2cd37c2e87780f9f00a732367838b
parent a6c91cdb4c19093ac83856f165b062ef35202a87
parent 705a6649b99c6116561985dc677d66df08e7b246

Merge "Ensure root repository is a FileRepository"

src/main/java/com/googlesource/gerrit/plugins/gitrepometrics/UpdateGitMetricsTask.java

diff --git a/src/main/java/com/googlesource/gerrit/plugins/gitrepometrics/UpdateGitMetricsTask.java b/src/main/java/com/googlesource/gerrit/plugins/gitrepometrics/UpdateGitMetricsTask.java
index bb885d3..191a5e7 100644
--- a/src/main/java/com/googlesource/gerrit/plugins/gitrepometrics/UpdateGitMetricsTask.java
+++ b/src/main/java/com/googlesource/gerrit/plugins/gitrepometrics/UpdateGitMetricsTask.java
@@ -19,6 +19,7 @@
 import com.google.gerrit.server.git.DelegateRepository;
 import com.google.gerrit.server.git.GitRepositoryManager;
 import com.google.inject.Inject;
+import com.google.inject.ProvisionException;
 import com.google.inject.assistedinject.Assisted;
 import com.googlesource.gerrit.plugins.gitrepometrics.collectors.GitRepoMetric;
 import java.io.IOException;
@@ -57,16 +58,11 @@
           "Running task to collect stats: repo %s, project %s",
           repository.getIdentifier(), projectName);
 
-      Repository unwrappedRepo =
-          repository instanceof DelegateRepository
-              ? ((DelegateRepository) repository).delegate()
-              : repository;
-
       gitRepoMetricsCache.getCollectors().stream()
           .forEach(
               metricsCollector -> {
                 metricsCollector.collect(
-                    (FileRepository) unwrappedRepo,
+                    getFileRepository(repository),
                     projectName,
                     metrics -> {
                       Map<GitRepoMetric, Long> newMetrics = new HashMap<>();
@@ -89,6 +85,18 @@
     }
   }
 
+  private FileRepository getFileRepository(Repository repo) {
+    if (repo instanceof DelegateRepository) {
+      return getFileRepository(((DelegateRepository) repo).delegate());
+    }
+
+    if (repo instanceof FileRepository) {
+      return (FileRepository) repo;
+    }
+
+    throw new ProvisionException("git-repo-metrics plugin can only be used with FileRepository");
+  }
+
   @Override
   public String toString() {
     return "UpdateGitMetricsTask " + projectName;