Remove declarations for exceptions that can never be thrown
Change-Id: Ie56dfca868cdca47d8d32a2bb6e9847dfd6e64c3
Signed-off-by: Edwin Kempin <ekempin@google.com>
diff --git a/src/main/java/com/googlesource/gerrit/plugins/findowners/Config.java b/src/main/java/com/googlesource/gerrit/plugins/findowners/Config.java
index 9497353..c09b3df 100644
--- a/src/main/java/com/googlesource/gerrit/plugins/findowners/Config.java
+++ b/src/main/java/com/googlesource/gerrit/plugins/findowners/Config.java
@@ -19,7 +19,6 @@
import com.google.gerrit.server.config.PluginConfigFactory;
import com.google.gerrit.server.project.ProjectState;
import com.google.gerrit.server.query.change.ChangeData;
-import com.google.gwtorm.server.OrmException;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
@@ -124,7 +123,7 @@
reportSyntaxError = value;
}
- static int getMinOwnerVoteLevel(ProjectState projectState, ChangeData c) throws OrmException {
+ static int getMinOwnerVoteLevel(ProjectState projectState, ChangeData c) {
if (projectState == null) {
log.error("Null projectState for change " + getChangeId(c));
return minOwnerVoteLevel;
diff --git a/src/main/java/com/googlesource/gerrit/plugins/findowners/OwnersValidator.java b/src/main/java/com/googlesource/gerrit/plugins/findowners/OwnersValidator.java
index 8d81574..1d27c47 100644
--- a/src/main/java/com/googlesource/gerrit/plugins/findowners/OwnersValidator.java
+++ b/src/main/java/com/googlesource/gerrit/plugins/findowners/OwnersValidator.java
@@ -51,7 +51,6 @@
import java.util.List;
import java.util.Map;
import java.util.Set;
-import java.util.concurrent.ExecutionException;
import java.util.regex.Matcher;
import java.util.regex.Pattern;
import org.eclipse.jgit.diff.RawText;
@@ -142,7 +141,7 @@
messages = performValidation(receiveEvent.commit, receiveEvent.revWalk, name, false);
}
}
- } catch (NoSuchProjectException | IOException | ExecutionException e) {
+ } catch (NoSuchProjectException | IOException e) {
throw new CommitValidationException("failed to check owners files", e);
}
if (hasError(messages)) {
@@ -153,8 +152,7 @@
@VisibleForTesting
List<CommitValidationMessage> performValidation(
- RevCommit c, RevWalk revWalk, String ownersFileName, boolean verbose)
- throws IOException, ExecutionException {
+ RevCommit c, RevWalk revWalk, String ownersFileName, boolean verbose) throws IOException {
// Collect all messages from all files.
List<CommitValidationMessage> messages = new LinkedList<>();
// Collect all email addresses from all files and check each address only once.