tree c797efed7fdf462f9778c7355f954fab076f2208
parent 0036927549e6f26ca8b630e461db9708f506f6cd
author Chih-Hung Hsieh <chh@google.com> 1548959513 -0800
committer Chih-Hung Hsieh <chh@google.com> 1549075606 -0800

Use StoredValues.PLUGIN_CONFIG_FACTORY

* Construct a Config object for each request to read latest
  configuration, instead of using static variables and functions.
  * Config parameters are retrieved from injected pluginConfigFactory
    or StoredValues.PLUGIN_CONFIG_FACTORY.
  * Use Config.PLUGIN_NAME as fixed plugin name; no more injected name.
  * Use config.getDefaultOwnersFileName to find configured file name.
  * Cache, OwnersDb, and Checker store and pass a PluginConfigFactory.
* One Cache per GitRepositoryManager.
  * Use repositoryManager instead of branch name for dbCache key.
* Coding style improvements:
  * Use private final for members only assigned in constructors.
  * Remove unnecessary setup code in PredicagteModule
  * Move overloaded findApproval functions to be next to each other.
  * Use simpler functions owner2Paths.size().

Change-Id: I68bfb879a5a6ab4d89562b8b45b0a73b713dd587