)]}'
{
  "commit": "b4897bb8c2c1ac050be28c6b97a82509e9924999",
  "tree": "7e6ae5fde1e50e6bdaa10e958e22b5725ad34302",
  "parents": [
    "b90571067a6f5f268f0e17062d0e783b5bf7f2b4"
  ],
  "author": {
    "name": "Antonio Barone",
    "email": "syntonyze@gmail.com",
    "time": "Wed Mar 20 12:51:15 2024 +0100"
  },
  "committer": {
    "name": "Antonio Barone",
    "email": "syntonyze@gmail.com",
    "time": "Thu Mar 28 17:09:58 2024 +0100"
  },
  "message": "Pass stream name and consumer to KinesisConsumer\n\nAn instance of `KinesisConsumer` was constucted through a factory that\nreceives the stream name and the message processor as arguments.\n\nSuch arguments however were ignored and the `KinesisConsumer` was\ninstantiated with the corresponding class fields set as `null`.\n\nThose class fields (`streamName` and `messageProcessor`) were then\npopulated when `subscribe()` was called, by providing again `streamName`\nand `messageProcessor` as arguments.\n\nThis was the wrong way of populating `streamName` and\n`messageProcessor`, it forced those arguments to be mutable and thus be\n`null`, until the `subscribe()` method was called.\n\nPass stream name and consumer to KinesisConsumer via the existing\nFactory by annotating them as @Assisted parameters. This allows to\nremove arguments from the `subscribe()` method, since the\n`KinesisConsumer` already has those set as class fields.\n\nChange-Id: I1b102fe55b769f4b2899d4ff3fa7e64d36355fa6\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "675d80196432287c6a91311e2b7939bf7729589c",
      "old_mode": 33188,
      "old_path": "src/main/java/com/googlesource/gerrit/plugins/kinesis/KinesisBrokerApi.java",
      "new_id": "27335fb86aeedc7eb073b9988f827c7b37e58a00",
      "new_mode": 33188,
      "new_path": "src/main/java/com/googlesource/gerrit/plugins/kinesis/KinesisBrokerApi.java"
    },
    {
      "type": "modify",
      "old_id": "d17595cc5ec7265555ff644e79905ddb787ec573",
      "old_mode": 33188,
      "old_path": "src/main/java/com/googlesource/gerrit/plugins/kinesis/KinesisConsumer.java",
      "new_id": "5bf551aee7e36e8f95d572597b31d134c8103c12",
      "new_mode": 33188,
      "new_path": "src/main/java/com/googlesource/gerrit/plugins/kinesis/KinesisConsumer.java"
    }
  ]
}
