tag: 4a997c86b0cfc8b178fd128cd87cbd572a8c80a0
tagger: David Pursehouse <dpursehouse@collab.net>
Fri Oct 25 08:46:49 2019 +0900
object: 767e6bfc028f438b4a1234ad6179aaba78a8b11e

v3.1.0-rc1

commit: 767e6bfc028f438b4a1234ad6179aaba78a8b11e
[log] [tgz]
author: Dmitrii Filippov <dmfilippov@google.com>
Tue Aug 13 15:18:32 2019 +0200
committer: Dmitrii Filippov <dmfilippov@google.com>
Fri Aug 16 10:48:59 2019 +0200
tree: 40c72f8a8792758c9622d9f6de9087f57cff8e53
parent: 56ebd4f7a2bf27f89aa11245ff77f7eefcf4a7d6 [diff]

Compatibility fix for Polymer 2

Polymer 2 uses shadow dom. Before the fix all styles were loaded as a
document-level styles. To load styles inside correct element this fix
logically separates plugin in 2 parts: gr-editor and codemirror-element.
The codemirror-element is a wrapper for codemirror and it incapsulates all
styles and scripts inside the element. gr-editor connects codemirror-element
with gerrit - it dynamically loads codemirror-element, set correct
options and adds event listeners.
Also, codemirror doesn't work with shadydom correctly. Because of it,
there 2 versions of codemirror-element - one is for shadowdom and antoher one
is for shadydom.

Bug: Issue 11143
Change-Id: I304cc73df1ea9a5c59fe295fe50c817ed266ffc2

BUILD[diff]
gr-editor/codemirror-element-shadowdom.html[Copied from gr-editor/codemirror-assets.html - diff]
gr-editor/codemirror-element-shadydom.html[Renamed from gr-editor/codemirror-assets.html - diff]
gr-editor/codemirror-element.css[Added - diff]
gr-editor/codemirror-element.js[Added - diff]
gr-editor/gr-editor.html[diff]
gr-editor/gr-editor.js[diff]
gr-editor/gr-editor_test.html[diff]

8 files changed

tree: 40c72f8a8792758c9622d9f6de9087f57cff8e53

README.md

CodeMirror Editor

A plugin that uses CodeMirror to provide a rich code editing experience in PolyGerrit.

Testing

This plugin uses polymer-cli to test.

After bower install, running polymer test -l chrome will run all tests in Chrome, and running polymer serve and navigating to http://127.0.0.1:8081/components/codemirror-editor/gr-editor/gr-editor_test.html allows for manual debugging.