CodeOwnersPluginConfigSnapshotTest: Fix flaky tests (second attempt)

The tests were flaky because the order of elements in sets is not fixed.

The first attempt to fix this was change Id758c5e4d which sorted the
override approvals in the tests before asserting them. However this
change missed to adapt one test.

Since doing the sorting in each test is error-prone and repetitive we
now do the sorting in
CodeOwnersPluginConfigSnapshot#getOverrideApprovals() and return an
ImmutableSortedSet. This way every caller can rely on the sorting.

Signed-off-by: Edwin Kempin <ekempin@google.com>
Change-Id: I38415ec45ea309b42fc5e7ed1cd98ca4c330fdd6
4 files changed
tree: 0268d719dc0f71b8e1189b73bcb2fec74513d27e
  1. java/
  2. javatests/
  3. proto/
  4. resources/
  5. test/
  6. ui/
  7. .eslintrc.json
  8. .gitignore
  9. .gitreview
  10. bower.json
  11. BUILD
  12. LICENSE
  13. package-lock.json
  14. package.json
  15. README.md
README.md

Gerrit Code Review code-owners plugin

This plugin provides support for defining code owners for files in a repository.

If the code-owners plugin is enabled, changes can only be submitted if all touched files are covered by approvals from code owners.

Also see resources/Documentation/about.md.

IMPORTANT: Before installing/enabling the plugin follow the instructions from the setup guide, see resources/Documentation/setup-guide.md.