commit | ce52ad0ff924fc98a50ac95f791bbac14846e25d | [log] [tgz] |
---|---|---|
author | Edwin Kempin <ekempin@google.com> | Wed Apr 14 09:26:40 2021 +0200 |
committer | Edwin Kempin <ekempin@google.com> | Wed Apr 14 09:30:37 2021 +0200 |
tree | 0268d719dc0f71b8e1189b73bcb2fec74513d27e | |
parent | d87c40575536302047a51ac87466119efa0a2574 [diff] |
CodeOwnersPluginConfigSnapshotTest: Fix flaky tests (second attempt) The tests were flaky because the order of elements in sets is not fixed. The first attempt to fix this was change Id758c5e4d which sorted the override approvals in the tests before asserting them. However this change missed to adapt one test. Since doing the sorting in each test is error-prone and repetitive we now do the sorting in CodeOwnersPluginConfigSnapshot#getOverrideApprovals() and return an ImmutableSortedSet. This way every caller can rely on the sorting. Signed-off-by: Edwin Kempin <ekempin@google.com> Change-Id: I38415ec45ea309b42fc5e7ed1cd98ca4c330fdd6
This plugin provides support for defining code owners for files in a repository.
If the code-owners plugin is enabled, changes can only be submitted if all touched files are covered by approvals from code owners.
Also see resources/Documentation/about.md.
IMPORTANT: Before installing/enabling the plugin follow the instructions from the setup guide, see resources/Documentation/setup-guide.md.