tree 63eb7c7f478566ca28efd44b56749df56252015e
parent 2b609d51805f0b249b74b697cdd90fbd0a8ee027
author Edwin Kempin <ekempin@google.com> 1616151295 +0100
committer Edwin Kempin <ekempin@google.com> 1616151575 +0100

Fix resolving exempted users to accounts in background threads

The code-owners submit rule can be executed in background threads where
a current user is not available (e.g. when a change is indexed).
AccountResolver needs the current user to check the account visibility
and fails if it is not available. Hence we must not use AccountResolver
to resolve exempted users.

Using AccountResolver for this was also a mistake due to other reasons:
* it checks account visibility, which we don't want to do
* it may access the account index, which we also don't want to do
* it searched over all account fields, but we are only interested in
  emails (the code handled this case, but it adds unnecessary
  complexity)

Fix all of this by using the Emails class, instead of AccountResolver,
to resolve exempted users.

Signed-off-by: Edwin Kempin <ekempin@google.com>
Change-Id: I238d343a7c9b1a64b789f4f671707bb0227e52b8