| // Copyright (C) 2021 The Android Open Source Project |
| // |
| // Licensed under the Apache License, Version 2.0 (the "License"); |
| // you may not use this file except in compliance with the License. |
| // You may obtain a copy of the License at |
| // |
| // http://www.apache.org/licenses/LICENSE-2.0 |
| // |
| // Unless required by applicable law or agreed to in writing, software |
| // distributed under the License is distributed on an "AS IS" BASIS, |
| // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. |
| // See the License for the specific language governing permissions and |
| // limitations under the License. |
| |
| package com.google.gerrit.plugins.codeowners.backend; |
| |
| import static com.google.gerrit.acceptance.testsuite.project.TestProjectUpdate.allowLabel; |
| import static com.google.gerrit.plugins.codeowners.testing.FileCodeOwnerStatusSubject.assertThatCollection; |
| import static com.google.gerrit.server.group.SystemGroupBackend.REGISTERED_USERS; |
| |
| import com.google.common.collect.ImmutableMap; |
| import com.google.common.collect.ImmutableSet; |
| import com.google.gerrit.acceptance.TestAccount; |
| import com.google.gerrit.acceptance.config.GerritConfig; |
| import com.google.gerrit.acceptance.testsuite.project.ProjectOperations; |
| import com.google.gerrit.acceptance.testsuite.request.RequestScopeOperations; |
| import com.google.gerrit.entities.Change; |
| import com.google.gerrit.extensions.api.changes.ReviewInput; |
| import com.google.gerrit.plugins.codeowners.acceptance.AbstractCodeOwnersTest; |
| import com.google.gerrit.plugins.codeowners.backend.config.GeneralConfig; |
| import com.google.gerrit.plugins.codeowners.common.CodeOwnerStatus; |
| import com.google.gerrit.plugins.codeowners.util.JgitPath; |
| import com.google.gerrit.server.notedb.ChangeNotes; |
| import com.google.gerrit.server.util.AccountTemplateUtil; |
| import com.google.gerrit.testing.ConfigSuite; |
| import com.google.inject.Inject; |
| import java.nio.file.Path; |
| import java.nio.file.Paths; |
| import org.eclipse.jgit.internal.storage.dfs.InMemoryRepository; |
| import org.eclipse.jgit.junit.TestRepository; |
| import org.eclipse.jgit.lib.Config; |
| import org.junit.Before; |
| import org.junit.Test; |
| |
| /** Tests for {@link CodeOwnerApprovalCheck} with PROJECT_OWNERS as fallback code owners. */ |
| public class CodeOwnerApprovalCheckWithProjectOwnersAsFallbackCodeOwnersTest |
| extends AbstractCodeOwnersTest { |
| @Inject private ChangeNotes.Factory changeNotesFactory; |
| @Inject private RequestScopeOperations requestScopeOperations; |
| @Inject private ProjectOperations projectOperations; |
| |
| private CodeOwnerApprovalCheck codeOwnerApprovalCheck; |
| |
| /** Returns a {@code gerrit.config} that configures all users as fallback code owners. */ |
| @ConfigSuite.Default |
| public static Config defaultConfig() { |
| Config cfg = new Config(); |
| cfg.setEnum( |
| "plugin", |
| "code-owners", |
| GeneralConfig.KEY_FALLBACK_CODE_OWNERS, |
| FallbackCodeOwners.PROJECT_OWNERS); |
| return cfg; |
| } |
| |
| @Before |
| public void setUpCodeOwnersPlugin() throws Exception { |
| codeOwnerApprovalCheck = plugin.getSysInjector().getInstance(CodeOwnerApprovalCheck.class); |
| } |
| |
| @Test |
| @GerritConfig(name = "plugin.code-owners.globalCodeOwner", value = "bot@example.com") |
| public void approvedByGlobalCodeOwner() throws Exception { |
| // Create a bot user that is a global code owner. |
| TestAccount bot = |
| accountCreator.create("bot", "bot@example.com", "Bot", /* displayName= */ null); |
| |
| // Create a change as a user that is not a code owner. |
| Path path = Paths.get("/foo/bar.baz"); |
| String changeId = |
| createChange(user, "Change Adding A File", JgitPath.of(path).get(), "file content") |
| .getChangeId(); |
| |
| // Verify that the file is not approved yet. |
| ImmutableSet<FileCodeOwnerStatus> fileCodeOwnerStatuses = getFileCodeOwnerStatuses(changeId); |
| assertThatCollection(fileCodeOwnerStatuses) |
| .containsExactly( |
| FileCodeOwnerStatus.addition(path, CodeOwnerStatus.INSUFFICIENT_REVIEWERS)); |
| |
| // Let the bot approve the change. |
| projectOperations |
| .project(project) |
| .forUpdate() |
| .add(allowLabel("Code-Review").ref("refs/heads/*").group(REGISTERED_USERS).range(-2, +2)) |
| .update(); |
| requestScopeOperations.setApiUser(bot.id()); |
| approve(changeId); |
| |
| // Check that the file is approved now. |
| requestScopeOperations.setApiUser(admin.id()); |
| fileCodeOwnerStatuses = getFileCodeOwnerStatuses(changeId); |
| assertThatCollection(fileCodeOwnerStatuses) |
| .containsExactly( |
| FileCodeOwnerStatus.addition( |
| path, |
| CodeOwnerStatus.APPROVED, |
| String.format( |
| "approved by %s who is a global code owner", |
| AccountTemplateUtil.getAccountTemplate(bot.id())))); |
| } |
| |
| @Test |
| @GerritConfig(name = "plugin.code-owners.globalCodeOwner", values = "bot@example.com") |
| public void globalCodeOwner_noImplicitApproval() throws Exception { |
| testImplicitlyApprovedByGlobalCodeOwner( |
| /* implicitApprovalsEnabled= */ false, /* uploaderMatchesChangeOwner= */ true); |
| } |
| |
| @Test |
| @GerritConfig(name = "plugin.code-owners.globalCodeOwner", values = "bot@example.com") |
| @GerritConfig(name = "plugin.code-owners.enableImplicitApprovals", value = "true") |
| public void globalCodeOwner_noImplicitApproval_uploaderDoesntMatchChangeOwner() throws Exception { |
| testImplicitlyApprovedByGlobalCodeOwner( |
| /* implicitApprovalsEnabled= */ true, /* uploaderMatchesChangeOwner= */ false); |
| } |
| |
| @Test |
| @GerritConfig(name = "plugin.code-owners.globalCodeOwner", values = "bot@example.com") |
| @GerritConfig(name = "plugin.code-owners.enableImplicitApprovals", value = "true") |
| public void globalCodeOwner_withImplicitApproval() throws Exception { |
| testImplicitlyApprovedByGlobalCodeOwner( |
| /* implicitApprovalsEnabled= */ true, /* uploaderMatchesChangeOwner= */ true); |
| } |
| |
| private void testImplicitlyApprovedByGlobalCodeOwner( |
| boolean implicitApprovalsEnabled, boolean uploaderMatchesChangeOwner) throws Exception { |
| TestAccount bot = |
| accountCreator.create("bot", "bot@example.com", "Bot", /* displayName= */ null); |
| TestAccount projectOwner = admin; |
| |
| Path path = Paths.get("/foo/bar.baz"); |
| String changeId = |
| createChange(bot, "Change Adding A File", JgitPath.of(path).get(), "file content") |
| .getChangeId(); |
| |
| if (uploaderMatchesChangeOwner) { |
| amendChange(bot, changeId); |
| } else { |
| amendChange(projectOwner, changeId); |
| } |
| |
| FileCodeOwnerStatus expectedFileCodeOwnerStatus; |
| if (implicitApprovalsEnabled && uploaderMatchesChangeOwner) { |
| expectedFileCodeOwnerStatus = |
| FileCodeOwnerStatus.addition( |
| path, |
| CodeOwnerStatus.APPROVED, |
| String.format( |
| "implicitly approved by the patch set uploader %s who is a global code" |
| + " owner", |
| AccountTemplateUtil.getAccountTemplate(bot.id()))); |
| } else { |
| expectedFileCodeOwnerStatus = |
| FileCodeOwnerStatus.addition(path, CodeOwnerStatus.INSUFFICIENT_REVIEWERS); |
| } |
| |
| ImmutableSet<FileCodeOwnerStatus> fileCodeOwnerStatuses = getFileCodeOwnerStatuses(changeId); |
| assertThatCollection(fileCodeOwnerStatuses).containsExactly(expectedFileCodeOwnerStatus); |
| } |
| |
| @Test |
| @GerritConfig(name = "plugin.code-owners.globalCodeOwner", value = "bot@example.com") |
| public void globalCodeOwnerAsReviewer() throws Exception { |
| // Create a bot user that is a global code owner. |
| TestAccount bot = |
| accountCreator.create("bot", "bot@example.com", "Bot", /* displayName= */ null); |
| |
| // Create a change as a user that is not a code owner. |
| Path path = Paths.get("/foo/bar.baz"); |
| String changeId = |
| createChange(user, "Change Adding A File", JgitPath.of(path).get(), "file content") |
| .getChangeId(); |
| |
| // Verify that the status of the file is INSUFFICIENT_REVIEWERS. |
| ImmutableSet<FileCodeOwnerStatus> fileCodeOwnerStatuses = getFileCodeOwnerStatuses(changeId); |
| assertThatCollection(fileCodeOwnerStatuses) |
| .containsExactly( |
| FileCodeOwnerStatus.addition(path, CodeOwnerStatus.INSUFFICIENT_REVIEWERS)); |
| |
| // Add the bot approve as reviewer. |
| gApi.changes().id(changeId).addReviewer(bot.email()); |
| |
| // Check that the status of the file is PENDING now. |
| requestScopeOperations.setApiUser(admin.id()); |
| fileCodeOwnerStatuses = getFileCodeOwnerStatuses(changeId); |
| assertThatCollection(fileCodeOwnerStatuses) |
| .containsExactly( |
| FileCodeOwnerStatus.addition( |
| path, |
| CodeOwnerStatus.PENDING, |
| String.format( |
| "reviewer %s is a global code owner", |
| AccountTemplateUtil.getAccountTemplate(bot.id())))); |
| |
| // Let the bot approve the change. |
| projectOperations |
| .project(project) |
| .forUpdate() |
| .add(allowLabel("Code-Review").ref("refs/heads/*").group(REGISTERED_USERS).range(-2, +2)) |
| .update(); |
| requestScopeOperations.setApiUser(bot.id()); |
| approve(changeId); |
| |
| // Check that the file is approved now. |
| requestScopeOperations.setApiUser(admin.id()); |
| fileCodeOwnerStatuses = getFileCodeOwnerStatuses(changeId); |
| assertThatCollection(fileCodeOwnerStatuses) |
| .containsExactly( |
| FileCodeOwnerStatus.addition( |
| path, |
| CodeOwnerStatus.APPROVED, |
| String.format( |
| "approved by %s who is a global code owner", |
| AccountTemplateUtil.getAccountTemplate(bot.id())))); |
| } |
| |
| @Test |
| @GerritConfig(name = "plugin.code-owners.globalCodeOwner", value = "*") |
| public void approvedByAnyoneWhenEveryoneIsGlobalCodeOwner() throws Exception { |
| // Create a change. |
| Path path = Paths.get("/foo/bar.baz"); |
| String changeId = |
| createChange(user, "Change Adding A File", JgitPath.of(path).get(), "file content") |
| .getChangeId(); |
| |
| // Verify that the file is not approved yet (the change owner is a global code owner, but |
| // implicit approvals are disabled). |
| ImmutableSet<FileCodeOwnerStatus> fileCodeOwnerStatuses = getFileCodeOwnerStatuses(changeId); |
| assertThatCollection(fileCodeOwnerStatuses) |
| .containsExactly( |
| FileCodeOwnerStatus.addition(path, CodeOwnerStatus.INSUFFICIENT_REVIEWERS)); |
| |
| // Add an approval by a user that is a code owner only through the global code ownership. |
| approve(changeId); |
| |
| // Check that the file is approved now. |
| requestScopeOperations.setApiUser(admin.id()); |
| fileCodeOwnerStatuses = getFileCodeOwnerStatuses(changeId); |
| assertThatCollection(fileCodeOwnerStatuses) |
| .containsExactly( |
| FileCodeOwnerStatus.addition( |
| path, |
| CodeOwnerStatus.APPROVED, |
| String.format( |
| "approved by %s who is a global code owner" |
| + " (all users are global code owners)", |
| AccountTemplateUtil.getAccountTemplate(admin.id())))); |
| } |
| |
| @Test |
| @GerritConfig(name = "plugin.code-owners.globalCodeOwner", value = "*") |
| public void everyoneIsGlobalCodeOwner_noImplicitApproval() throws Exception { |
| testImplicitlyApprovedByGlobalCodeOwnerWhenEveryoneIsGlobalCodeOwner( |
| /* implicitApprovalsEnabled= */ false, /* uploaderMatchesChangeOwner= */ true); |
| } |
| |
| @Test |
| @GerritConfig(name = "plugin.code-owners.globalCodeOwner", value = "*") |
| @GerritConfig(name = "plugin.code-owners.enableImplicitApprovals", value = "true") |
| public void everyoneIsGlobalCodeOwner_noImplicitApproval_uploaderDoesntMatchChangeOwner() |
| throws Exception { |
| testImplicitlyApprovedByGlobalCodeOwnerWhenEveryoneIsGlobalCodeOwner( |
| /* implicitApprovalsEnabled= */ true, /* uploaderMatchesChangeOwner= */ false); |
| } |
| |
| @Test |
| @GerritConfig(name = "plugin.code-owners.globalCodeOwner", value = "*") |
| @GerritConfig(name = "plugin.code-owners.enableImplicitApprovals", value = "true") |
| public void everyoneIsGlobalCodeOwner_withImplicitApproval() throws Exception { |
| testImplicitlyApprovedByGlobalCodeOwnerWhenEveryoneIsGlobalCodeOwner( |
| /* implicitApprovalsEnabled= */ true, /* uploaderMatchesChangeOwner= */ true); |
| } |
| |
| private void testImplicitlyApprovedByGlobalCodeOwnerWhenEveryoneIsGlobalCodeOwner( |
| boolean implicitApprovalsEnabled, boolean uploaderMatchesChangeOwner) throws Exception { |
| TestAccount projectOwner = admin; |
| TestAccount otherProjectOwner = accountCreator.admin2(); |
| |
| // Create a change as a user that is a project code owner. |
| Path path = Paths.get("/foo/bar.baz"); |
| String changeId = |
| createChange("Change Adding A File", JgitPath.of(path).get(), "file content").getChangeId(); |
| |
| if (uploaderMatchesChangeOwner) { |
| amendChange(projectOwner, changeId); |
| } else { |
| amendChange(otherProjectOwner, changeId); |
| } |
| |
| FileCodeOwnerStatus expectedFileCodeOwnerStatus; |
| if (implicitApprovalsEnabled && uploaderMatchesChangeOwner) { |
| expectedFileCodeOwnerStatus = |
| FileCodeOwnerStatus.addition( |
| path, |
| CodeOwnerStatus.APPROVED, |
| String.format( |
| "implicitly approved by the patch set uploader %s who is a global code owner" |
| + " (all users are global code owners)", |
| AccountTemplateUtil.getAccountTemplate(projectOwner.id()))); |
| } else { |
| expectedFileCodeOwnerStatus = |
| FileCodeOwnerStatus.addition(path, CodeOwnerStatus.INSUFFICIENT_REVIEWERS); |
| } |
| |
| ImmutableSet<FileCodeOwnerStatus> fileCodeOwnerStatuses = getFileCodeOwnerStatuses(changeId); |
| assertThatCollection(fileCodeOwnerStatuses).containsExactly(expectedFileCodeOwnerStatus); |
| } |
| |
| @Test |
| @GerritConfig(name = "plugin.code-owners.globalCodeOwner", value = "*") |
| public void anyReviewerWhenEveryoneIsGlobalCodeOwner() throws Exception { |
| // Create a change as a user that is a code owner only through the global code ownership. |
| Path path = Paths.get("/foo/bar.baz"); |
| String changeId = |
| createChange("Change Adding A File", JgitPath.of(path).get(), "file content").getChangeId(); |
| |
| // Verify that the status of the file is INSUFFICIENT_REVIEWERS (since there is no implicit |
| // approval by default). |
| ImmutableSet<FileCodeOwnerStatus> fileCodeOwnerStatuses = getFileCodeOwnerStatuses(changeId); |
| assertThatCollection(fileCodeOwnerStatuses) |
| .containsExactly( |
| FileCodeOwnerStatus.addition(path, CodeOwnerStatus.INSUFFICIENT_REVIEWERS)); |
| |
| // Add a user as reviewer that is a code owner only through the global code ownership. |
| gApi.changes().id(changeId).addReviewer(user.email()); |
| |
| // Check that the status of the file is PENDING now. |
| fileCodeOwnerStatuses = getFileCodeOwnerStatuses(changeId); |
| assertThatCollection(fileCodeOwnerStatuses) |
| .containsExactly( |
| FileCodeOwnerStatus.addition( |
| path, |
| CodeOwnerStatus.PENDING, |
| String.format( |
| "reviewer %s is a global code owner (all users are global code owners)", |
| AccountTemplateUtil.getAccountTemplate(user.id())))); |
| } |
| |
| @Test |
| public void getStatus_insufficientReviewers() throws Exception { |
| TestAccount user2 = accountCreator.user2(); |
| TestAccount user3 = |
| accountCreator.create("user3", "user3@example.com", "User3", /* displayName= */ null); |
| |
| // Create change with a user that is not a project owner. |
| Path path = Paths.get("/foo/bar.baz"); |
| String changeId = |
| createChange(user, "Change Adding A File", JgitPath.of(path).get(), "file content") |
| .getChangeId(); |
| |
| // Add a reviewer that is not a project owner. |
| gApi.changes().id(changeId).addReviewer(user2.email()); |
| |
| // Add a Code-Review+1 (= code owner approval) from a user that is not a project owner. |
| requestScopeOperations.setApiUser(user3.id()); |
| recommend(changeId); |
| |
| ImmutableSet<FileCodeOwnerStatus> fileCodeOwnerStatuses = getFileCodeOwnerStatuses(changeId); |
| assertThatCollection(fileCodeOwnerStatuses) |
| .containsExactly( |
| FileCodeOwnerStatus.addition(path, CodeOwnerStatus.INSUFFICIENT_REVIEWERS)); |
| } |
| |
| @Test |
| public void getStatus_pending() throws Exception { |
| TestAccount user2 = accountCreator.user2(); |
| |
| // Create change with a user that is not a project owner. |
| Path path = Paths.get("/foo/bar.baz"); |
| String changeId = |
| createChange(user, "Change Adding A File", JgitPath.of(path).get(), "file content") |
| .getChangeId(); |
| |
| // Add a reviewer that is a project owner. |
| gApi.changes().id(changeId).addReviewer(admin.email()); |
| |
| // Add a Code-Review+1 (= code owner approval) from a user that is not a project owner. |
| requestScopeOperations.setApiUser(user2.id()); |
| recommend(changeId); |
| |
| ImmutableSet<FileCodeOwnerStatus> fileCodeOwnerStatuses = getFileCodeOwnerStatuses(changeId); |
| assertThatCollection(fileCodeOwnerStatuses) |
| .containsExactly( |
| FileCodeOwnerStatus.addition( |
| path, |
| CodeOwnerStatus.PENDING, |
| String.format( |
| "reviewer %s is a fallback code owner" |
| + " (all project owners are fallback code owners)", |
| AccountTemplateUtil.getAccountTemplate(admin.id())))); |
| } |
| |
| @Test |
| public void getStatus_approved() throws Exception { |
| // Create change with a user that is not a project owner. |
| Path path = Paths.get("/foo/bar.baz"); |
| String changeId = |
| createChange(user, "Change Adding A File", JgitPath.of(path).get(), "file content") |
| .getChangeId(); |
| |
| // Add a Code-Review+1 from a project owner (by default this counts as code owner approval). |
| requestScopeOperations.setApiUser(admin.id()); |
| recommend(changeId); |
| |
| ImmutableSet<FileCodeOwnerStatus> fileCodeOwnerStatuses = getFileCodeOwnerStatuses(changeId); |
| assertThatCollection(fileCodeOwnerStatuses) |
| .containsExactly( |
| FileCodeOwnerStatus.addition( |
| path, |
| CodeOwnerStatus.APPROVED, |
| String.format( |
| "approved by %s who is a fallback code owner" |
| + " (all project owners are fallback code owners)", |
| AccountTemplateUtil.getAccountTemplate(admin.id())))); |
| } |
| |
| @Test |
| public void getStatus_noImplicitApproval() throws Exception { |
| testImplicitApprovalOnGetStatus( |
| /* implicitApprovalsEnabled= */ false, /* uploaderMatchesChangeOwner= */ true); |
| } |
| |
| @Test |
| @GerritConfig(name = "plugin.code-owners.enableImplicitApprovals", value = "true") |
| public void getStatus_noImplicitApproval_uploaderDoesntMatchChangeOwner() throws Exception { |
| testImplicitApprovalOnGetStatus( |
| /* implicitApprovalsEnabled= */ true, /* uploaderMatchesChangeOwner= */ false); |
| } |
| |
| @Test |
| @GerritConfig(name = "plugin.code-owners.enableImplicitApprovals", value = "true") |
| public void getStatus_withImplicitApproval() throws Exception { |
| testImplicitApprovalOnGetStatus( |
| /* implicitApprovalsEnabled= */ true, /* uploaderMatchesChangeOwner= */ true); |
| } |
| |
| private void testImplicitApprovalOnGetStatus( |
| boolean implicitApprovalsEnabled, boolean uploaderMatchesChangeOwner) throws Exception { |
| TestAccount projectOwner = admin; |
| |
| // Create change with a user that is not a project owner. |
| Path path = Paths.get("/foo/bar.baz"); |
| String changeId = |
| createChange("Change Adding A File", JgitPath.of(path).get(), "file content").getChangeId(); |
| |
| if (uploaderMatchesChangeOwner) { |
| amendChange(projectOwner, changeId); |
| } else { |
| amendChange(user, changeId); |
| } |
| |
| FileCodeOwnerStatus expectedFileCodeOwnerStatus; |
| if (implicitApprovalsEnabled && uploaderMatchesChangeOwner) { |
| expectedFileCodeOwnerStatus = |
| FileCodeOwnerStatus.addition( |
| path, |
| CodeOwnerStatus.APPROVED, |
| String.format( |
| "implicitly approved by the patch set uploader %s who is a fallback code" |
| + " owner (all project owners are fallback code owners)", |
| AccountTemplateUtil.getAccountTemplate(projectOwner.id()))); |
| } else { |
| expectedFileCodeOwnerStatus = |
| FileCodeOwnerStatus.addition(path, CodeOwnerStatus.INSUFFICIENT_REVIEWERS); |
| } |
| |
| ImmutableSet<FileCodeOwnerStatus> fileCodeOwnerStatuses = getFileCodeOwnerStatuses(changeId); |
| assertThatCollection(fileCodeOwnerStatuses).containsExactly(expectedFileCodeOwnerStatus); |
| } |
| |
| @Test |
| @GerritConfig(name = "plugin.code-owners.enableImplicitApprovals", value = "true") |
| public void getStatus_noImplicitlyApprovalByPatchSetUploaderThatDoesntOwnTheChange() |
| throws Exception { |
| TestAccount admin2 = accountCreator.admin2(); |
| |
| // Create change with a user that is a project owner. |
| Path path = Paths.get("/foo/bar.baz"); |
| String changeId = |
| createChange("Change Adding A File", JgitPath.of(path).get(), "file content").getChangeId(); |
| |
| // Amend change with a user that is another project owner. |
| amendChange(admin2, changeId); |
| |
| ImmutableSet<FileCodeOwnerStatus> fileCodeOwnerStatuses = getFileCodeOwnerStatuses(changeId); |
| assertThatCollection(fileCodeOwnerStatuses) |
| .containsExactly( |
| FileCodeOwnerStatus.addition(path, CodeOwnerStatus.INSUFFICIENT_REVIEWERS)); |
| } |
| |
| @Test |
| @GerritConfig(name = "plugin.code-owners.overrideApproval", value = "Owners-Override+1") |
| public void getStatus_overrideApprovesAllFiles() throws Exception { |
| createOwnersOverrideLabel(); |
| |
| // Create a change with a user that is not a project owner. |
| TestRepository<InMemoryRepository> testRepo = cloneProject(project, user); |
| String path1 = "bar/baz.config"; |
| String path2 = "foo/baz.config"; |
| String changeId = |
| pushFactory |
| .create( |
| user.newIdent(), |
| testRepo, |
| "Test Change", |
| ImmutableMap.of( |
| path2, "content", |
| path1, "other content")) |
| .to("refs/for/master") |
| .getChangeId(); |
| |
| // Without Owners-Override approval the expected status is INSUFFICIENT_REVIEWERS. |
| ImmutableSet<FileCodeOwnerStatus> fileCodeOwnerStatuses = getFileCodeOwnerStatuses(changeId); |
| assertThatCollection(fileCodeOwnerStatuses) |
| .containsExactly( |
| FileCodeOwnerStatus.addition(path1, CodeOwnerStatus.INSUFFICIENT_REVIEWERS), |
| FileCodeOwnerStatus.addition(path2, CodeOwnerStatus.INSUFFICIENT_REVIEWERS)); |
| |
| // Add an override approval. |
| gApi.changes().id(changeId).current().review(new ReviewInput().label("Owners-Override", 1)); |
| |
| // With Owners-Override approval the expected status is APPROVED. |
| fileCodeOwnerStatuses = getFileCodeOwnerStatuses(changeId); |
| assertThatCollection(fileCodeOwnerStatuses) |
| .containsExactly( |
| FileCodeOwnerStatus.addition( |
| path1, |
| CodeOwnerStatus.APPROVED, |
| String.format( |
| "override approval Owners-Override+1 by %s is present", |
| AccountTemplateUtil.getAccountTemplate(admin.id()))), |
| FileCodeOwnerStatus.addition( |
| path2, |
| CodeOwnerStatus.APPROVED, |
| String.format( |
| "override approval Owners-Override+1 by %s is present", |
| AccountTemplateUtil.getAccountTemplate(admin.id())))); |
| } |
| |
| @Test |
| @GerritConfig( |
| name = "plugin.code-owners.overrideApproval", |
| values = {"Owners-Override+1", "Another-Override+1"}) |
| public void getStatus_anyOverrideApprovesAllFiles() throws Exception { |
| createOwnersOverrideLabel(); |
| createOwnersOverrideLabel("Another-Override"); |
| |
| // Create a change with a user that is not a project owner. |
| TestRepository<InMemoryRepository> testRepo = cloneProject(project, user); |
| String path1 = "bar/baz.config"; |
| String path2 = "foo/baz.config"; |
| String changeId = |
| pushFactory |
| .create( |
| user.newIdent(), |
| testRepo, |
| "Test Change", |
| ImmutableMap.of( |
| path2, "content", |
| path1, "other content")) |
| .to("refs/for/master") |
| .getChangeId(); |
| |
| // Without override approval the expected status is INSUFFICIENT_REVIEWERS. |
| ImmutableSet<FileCodeOwnerStatus> fileCodeOwnerStatuses = getFileCodeOwnerStatuses(changeId); |
| assertThatCollection(fileCodeOwnerStatuses) |
| .containsExactly( |
| FileCodeOwnerStatus.addition(path1, CodeOwnerStatus.INSUFFICIENT_REVIEWERS), |
| FileCodeOwnerStatus.addition(path2, CodeOwnerStatus.INSUFFICIENT_REVIEWERS)); |
| |
| // Add an override approval (by a user that is not a project owners, and hence no code owner). |
| requestScopeOperations.setApiUser(user.id()); |
| gApi.changes().id(changeId).current().review(new ReviewInput().label("Owners-Override", 1)); |
| |
| // With override approval the expected status is APPROVED. |
| fileCodeOwnerStatuses = getFileCodeOwnerStatuses(changeId); |
| assertThatCollection(fileCodeOwnerStatuses) |
| .containsExactly( |
| FileCodeOwnerStatus.addition( |
| path1, |
| CodeOwnerStatus.APPROVED, |
| String.format( |
| "override approval Owners-Override+1 by %s is present", |
| AccountTemplateUtil.getAccountTemplate(user.id()))), |
| FileCodeOwnerStatus.addition( |
| path2, |
| CodeOwnerStatus.APPROVED, |
| String.format( |
| "override approval Owners-Override+1 by %s is present", |
| AccountTemplateUtil.getAccountTemplate(user.id())))); |
| |
| // Delete the override approval. |
| gApi.changes().id(changeId).current().review(new ReviewInput().label("Owners-Override", 0)); |
| |
| // Without override approval the expected status is INSUFFICIENT_REVIEWERS. |
| fileCodeOwnerStatuses = getFileCodeOwnerStatuses(changeId); |
| assertThatCollection(fileCodeOwnerStatuses) |
| .containsExactly( |
| FileCodeOwnerStatus.addition(path1, CodeOwnerStatus.INSUFFICIENT_REVIEWERS), |
| FileCodeOwnerStatus.addition(path2, CodeOwnerStatus.INSUFFICIENT_REVIEWERS)); |
| |
| // Add another override approval. |
| gApi.changes().id(changeId).current().review(new ReviewInput().label("Another-Override", 1)); |
| |
| // With override approval the expected status is APPROVED. |
| fileCodeOwnerStatuses = getFileCodeOwnerStatuses(changeId); |
| assertThatCollection(fileCodeOwnerStatuses) |
| .containsExactly( |
| FileCodeOwnerStatus.addition( |
| path1, |
| CodeOwnerStatus.APPROVED, |
| String.format( |
| "override approval Another-Override+1 by %s is present", |
| AccountTemplateUtil.getAccountTemplate(user.id()))), |
| FileCodeOwnerStatus.addition( |
| path2, |
| CodeOwnerStatus.APPROVED, |
| String.format( |
| "override approval Another-Override+1 by %s is present", |
| AccountTemplateUtil.getAccountTemplate(user.id())))); |
| } |
| |
| @Test |
| public void projectOwnersAreNotCodeOwnersIfDefaultCodeOwnerConfigExists() throws Exception { |
| TestAccount user2 = accountCreator.user2(); |
| |
| setAsDefaultCodeOwners(user); |
| |
| // Create a change as a user that is neither a code owner nor a project owner. |
| Path path = Paths.get("/foo/bar.baz"); |
| String changeId = |
| createChange(user2, "Change Adding A File", JgitPath.of(path).get(), "file content") |
| .getChangeId(); |
| |
| // Verify that the file is not approved yet. |
| ImmutableSet<FileCodeOwnerStatus> fileCodeOwnerStatuses = getFileCodeOwnerStatuses(changeId); |
| assertThatCollection(fileCodeOwnerStatuses) |
| .containsExactly( |
| FileCodeOwnerStatus.addition(path, CodeOwnerStatus.INSUFFICIENT_REVIEWERS)); |
| |
| // Let the project owner approve the change. |
| requestScopeOperations.setApiUser(admin.id()); |
| approve(changeId); |
| |
| // Verify that the file is not approved yet |
| fileCodeOwnerStatuses = getFileCodeOwnerStatuses(changeId); |
| assertThatCollection(fileCodeOwnerStatuses) |
| .containsExactly( |
| FileCodeOwnerStatus.addition(path, CodeOwnerStatus.INSUFFICIENT_REVIEWERS)); |
| |
| // Let the code owner approve the change. |
| projectOperations |
| .project(project) |
| .forUpdate() |
| .add(allowLabel("Code-Review").ref("refs/heads/*").group(REGISTERED_USERS).range(-2, +2)) |
| .update(); |
| requestScopeOperations.setApiUser(user.id()); |
| approve(changeId); |
| |
| // Check that the file is approved now. |
| requestScopeOperations.setApiUser(admin.id()); |
| fileCodeOwnerStatuses = getFileCodeOwnerStatuses(changeId); |
| assertThatCollection(fileCodeOwnerStatuses) |
| .containsExactly( |
| FileCodeOwnerStatus.addition( |
| path, |
| CodeOwnerStatus.APPROVED, |
| String.format( |
| "approved by %s who is a default code owner", |
| AccountTemplateUtil.getAccountTemplate(user.id())))); |
| } |
| |
| private ImmutableSet<FileCodeOwnerStatus> getFileCodeOwnerStatuses(String changeId) |
| throws Exception { |
| return codeOwnerApprovalCheck.getFileStatusesAsSet( |
| getChangeNotes(changeId), /* start= */ 0, /* limit= */ 0); |
| } |
| |
| private ChangeNotes getChangeNotes(String changeId) throws Exception { |
| return changeNotesFactory.create(project, Change.id(gApi.changes().id(changeId).get()._number)); |
| } |
| } |
