commit 5c5e007a41f27844754a3f2624467a09173ff77d
author Edwin Kempin <ekempin@google.com> Thu Jun 10 14:15:43 2021 +0200
committer Edwin Kempin <ekempin@google.com> Thu Jun 10 14:30:59 2021 +0200
tree 5e885d647ed792f511cb501bf0179a81ac3cb5e9
parent 2c660340720d1e4cc7ae58ca948cd1cfe5955897

Test that an import of a non code owner config file is ignored

Code owner config files can only import other code owner config files,
but not arbitrary files. For the find-owners backend code owner config
files must be named 'OWNERS', '<prefix>_OWNERS' or 'OWNERS_<extension>'.
Imports of files with other names are silently ignored. Add a test for
this.

Signed-off-by: Edwin Kempin <ekempin@google.com>
Change-Id: I49ce0653a854a44010f259cc7e8d193353f32cdd

javatests/com/google/gerrit/plugins/codeowners/backend/PathCodeOwnersTest.java

diff --git a/javatests/com/google/gerrit/plugins/codeowners/backend/PathCodeOwnersTest.java b/javatests/com/google/gerrit/plugins/codeowners/backend/PathCodeOwnersTest.java
index dce1d52..486ea88 100644
--- a/javatests/com/google/gerrit/plugins/codeowners/backend/PathCodeOwnersTest.java
+++ b/javatests/com/google/gerrit/plugins/codeowners/backend/PathCodeOwnersTest.java
@@ -502,6 +502,47 @@
   }
 
   @Test
+  public void importOfNonCodeOwnerConfigFileIsIgnored() throws Exception {
+    // create a file that looks like a code owner config file, but which has a name that is not
+    // allowed as code owner config file
+    codeOwnerConfigOperations
+        .newCodeOwnerConfig()
+        .project(project)
+        .branch("master")
+        .folderPath("/")
+        .fileName("FOO")
+        .addCodeOwnerEmail(user.email())
+        .create();
+
+    // create config with import of non code owner config file
+    CodeOwnerConfig.Key importingCodeOwnerConfigKey =
+        codeOwnerConfigOperations
+            .newCodeOwnerConfig()
+            .project(project)
+            .branch("master")
+            .folderPath("/")
+            .addImport(CodeOwnerConfigReference.create(CodeOwnerConfigImportMode.ALL, "/FOO"))
+            .addCodeOwnerSet(CodeOwnerSet.builder().addCodeOwnerEmail(admin.email()).build())
+            .create();
+
+    Optional<PathCodeOwners> pathCodeOwners =
+        pathCodeOwnersFactory.create(
+            transientCodeOwnerConfigCacheProvider.get(),
+            importingCodeOwnerConfigKey,
+            projectOperations.project(project).getHead("master"),
+            Paths.get("/foo.md"));
+    assertThat(pathCodeOwners).isPresent();
+
+    // Expectation: we get the global code owner from the importing code owner config, the
+    // import of the non code owner config file is silently ignored
+    PathCodeOwnersResult pathCodeOwnersResult = pathCodeOwners.get().resolveCodeOwnerConfig().get();
+    assertThat(pathCodeOwnersResult.getPathCodeOwners())
+        .comparingElementsUsing(hasEmail())
+        .containsExactly(admin.email());
+    assertThat(pathCodeOwnersResult.hasUnresolvedImports()).isTrue();
+  }
+
+  @Test
   public void importGlobalCodeOwners_importModeAll() throws Exception {
     testImportGlobalCodeOwners(CodeOwnerConfigImportMode.ALL);
   }