)]}'
{
  "commit": "0c7d0408e330823f5ffe78564c18d56b3628738a",
  "tree": "8ae7c73b2249741a53d40d529c6fcd49a9182baa",
  "parents": [
    "1ed330eee5bb8f6d81d5f423094148d91b6bada5"
  ],
  "author": {
    "name": "Edwin Kempin",
    "email": "ekempin@google.com",
    "time": "Wed Nov 25 13:53:09 2020 +0100"
  },
  "committer": {
    "name": "Edwin Kempin",
    "email": "ekempin@google.com",
    "time": "Fri Nov 27 13:52:31 2020 +0100"
  },
  "message": "AbstractRequiredApprovalConfigTest: Improve readability of 2 tests\n\n1. testGetFromGlobalPluginConfig:\nThis method in the base class verified that \"Code-Review+2\" was\nconfigured, but this configuration was done in the child classes via an\nannotation. Due to this just looking at the\ntestGetFromGlobalPluginConfig() method it\u0027s unclear how the assertions\ncan work. To understand the assertions one must look at the calling\ncode. This is bad. Inline the method to improve the test readability,\neven if it means that a small amount of code is being duplicated. After\ndoing this we can now use a more realistic label for the\ngetFromGlobalPluginConfig() test in OverrideApprovalConfigTest.\n\n2. testCannotGetFromGlobalPluginConfigIfConfigIsInvalid:\nAgain the assertion only makes sense if you know the calling code.\nProvide the invalid value as input, so that the assertion become more\nreadable.\n\nSigned-off-by: Edwin Kempin \u003cekempin@google.com\u003e\nChange-Id: I22a639cb878787fff8134ec4f3fcf397d21a1a20\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "acb5c9f37d5cc0620caa2094ebafaf1edd6e8c79",
      "old_mode": 33188,
      "old_path": "javatests/com/google/gerrit/plugins/codeowners/config/AbstractRequiredApprovalConfigTest.java",
      "new_id": "c9e6b364c74664272c29bd9d1ec884dc8bb542f5",
      "new_mode": 33188,
      "new_path": "javatests/com/google/gerrit/plugins/codeowners/config/AbstractRequiredApprovalConfigTest.java"
    },
    {
      "type": "modify",
      "old_id": "343ee30cd892c4b8f5855227705ef272afbe5a08",
      "old_mode": 33188,
      "old_path": "javatests/com/google/gerrit/plugins/codeowners/config/OverrideApprovalConfigTest.java",
      "new_id": "3591eca8a550cac90fb885cc5d62b79ba7678cc5",
      "new_mode": 33188,
      "new_path": "javatests/com/google/gerrit/plugins/codeowners/config/OverrideApprovalConfigTest.java"
    },
    {
      "type": "modify",
      "old_id": "53c0fa218637d80807dd4b2fffc04e9537cc1fc0",
      "old_mode": 33188,
      "old_path": "javatests/com/google/gerrit/plugins/codeowners/config/RequiredApprovalConfigTest.java",
      "new_id": "198ac0cb84173fd5409f3bd4b6c1f5e0cd78a2c1",
      "new_mode": 33188,
      "new_path": "javatests/com/google/gerrit/plugins/codeowners/config/RequiredApprovalConfigTest.java"
    }
  ]
}