)]}'
{
  "commit": "004aceb3163f769770c672ca4a0a20091b671f70",
  "tree": "431c87a87f5a9dfa1ed77638450bd2149ea03839",
  "parents": [
    "08a2164e5a9a0e70eadeaeb549924b37ceed086b"
  ],
  "author": {
    "name": "Edwin Kempin",
    "email": "ekempin@google.com",
    "time": "Mon Mar 11 07:02:43 2024 +0000"
  },
  "committer": {
    "name": "Patrick Hiesel",
    "email": "hiesel@google.com",
    "time": "Mon Mar 11 09:28:41 2024 +0000"
  },
  "message": "Show that the overrideIf of a configured Code-Owners SR has no effect\n\nWhether a change is code-owner approved is checked by the (hard-coded)\ncode owners submit rule. This submit rule respects overrides that comply\nwith the label that is configured as override in the code-owners plugin\nconfiguration.\n\nIf a Code-Owners submit requirement is manually configured in\nproject.config it conflicts with the (hard-coded) code owners submit\nrule. If submit requirements conflict the change only gets submittable\nwhen both submit requirements pass.\n\nThis means if the Code-Owners submit requirement has a different\noverrideIf condition than what\u0027s configured in the code-owners plugin\nconfiguration it has no effect:\n\n1. If the overrideIf is satisfied it doesn\u0027t count as an override for\n   the (hard-coded) code owners submit rule so this submit rule is still\n   not passing and hence the change doesn\u0027t get submittable.\n\n2. If the override that is configured in the code-owners plugin\n   configuration is satisfied the (hard-coded) code owners submit rule\n   is passing. If the Code-Owners submit requirement uses\n   \"has:approval_code-owners\" as submittableIf condition it is passing\n   now too since \"has:approval_code-owners\" just means to check if the\n   (hard-coded) code owners submit rule passes.\n\nThis means the overrideIf condition of a configured Code-Owners submit\nrequirement can neither replace nor add to the override condition that\nis configured in the code-owners plugin configuration.\n\nThis also means defining a Code-Owners submit requirement that has an\noverrideIf condition that is different from the override condition that\nis configured in the code-owners plugin configuration has no effect and\nis only confusing as the overrideIf condition from the Code-Owners\nsubmit requirement is shown in the UI but doesn\u0027t work.\n\nChange-Id: I5bfe4a45ad4e2ec67fae5ec3681012537e7b6a63\nSigned-off-by: Edwin Kempin \u003cekempin@google.com\u003e\nReviewed-on: https://gerrit-review.googlesource.com/c/plugins/code-owners/+/412560\nReviewed-by: Patrick Hiesel \u003chiesel@google.com\u003e\nTested-by: Zuul \u003czuul-63@gerritcodereview-ci.iam.gserviceaccount.com\u003e\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "618f5df9aeab9e653b2bdda16acef4ed444db2a1",
      "old_mode": 33188,
      "old_path": "javatests/com/google/gerrit/plugins/codeowners/acceptance/api/CodeOwnerSubmitRuleIT.java",
      "new_id": "e078738d0720ff5df70b546027045ab0a2d0182e",
      "new_mode": 33188,
      "new_path": "javatests/com/google/gerrit/plugins/codeowners/acceptance/api/CodeOwnerSubmitRuleIT.java"
    }
  ]
}