tree be7a6ba0b3716f5954c9d609987c76f268fdae64
parent 9d7d441bfa438ecd2f49973d5e4008ad225429ff
author Dave Borowitz <dborowitz@google.com> 1556809566 -0700
committer Dave Borowitz <dborowitz@google.com> 1556809718 -0700

ChecksSubmitRule: Catch all RuntimeExceptions

This used to catch the checked OrmException, and was converted
mechanically to StorageException without considering the fact that
StorageException is now unchecked. In fact, the intent of this catch
block is to catch any type of unexpected exception.

These are the only instances of catching StorageException in the plugin:

$ find . -name \*.java | xargs grep -P '(catch \(|\|) *StorageException'
./java/com/google/gerrit/plugins/checks/rules/ChecksSubmitRule.java:    } catch (StorageException e) {
./java/com/google/gerrit/plugins/checks/rules/ChecksSubmitRule.java:    } catch (StorageException e) {

Change-Id: I257382adaee7d03ba6d8a3ea8e0550ed0f6f1ee1