ChecksSubmitRule: Catch all RuntimeExceptions
This used to catch the checked OrmException, and was converted
mechanically to StorageException without considering the fact that
StorageException is now unchecked. In fact, the intent of this catch
block is to catch any type of unexpected exception.
These are the only instances of catching StorageException in the plugin:
$ find . -name \*.java | xargs grep -P '(catch \(|\|) *StorageException'
./java/com/google/gerrit/plugins/checks/rules/ChecksSubmitRule.java: } catch (StorageException e) {
./java/com/google/gerrit/plugins/checks/rules/ChecksSubmitRule.java: } catch (StorageException e) {
Change-Id: I257382adaee7d03ba6d8a3ea8e0550ed0f6f1ee1
2 files changed
