tree 6172c452f5fc7b0e7951092e4755cdcb184f1aa4
parent 2d04a03be5dd193b7a191be590eee9e4f4d3428e
author Edwin Kempin <ekempin@google.com> 1552308037 +0100
committer Edwin Kempin <ekempin@google.com> 1552308607 +0100

Do not require Administrate Checkers to view checks on a change

ChecksImpl#id(CheckerUuid) used the checkers API to verify that a
checker exists. This is bad because the checkers API requires the
Administrate Checkers capability to view checkers. Consequently viewing
checks of a change required this capability too.

Requiring Administrate Checkers for viewing checks on a visible change
was not intended. To fix this use the internal API to verify the checker
existence instead.

This also improves the error message when asking for checks of a
non-existing checker.

Signed-off-by: Edwin Kempin <ekempin@google.com>
Change-Id: I883bf7d439e294ecd5d4e00d85a79b000d5b717e