tree bdfb3081855ef379f52d4a7eb37d0b1658c1b236
parent 1373d88927ca6708e1fd37e0b5bbf10cbca91765
author Jonas Bergler <jonas@bergler.name> 1611258475 -0800
committer Jonas Bergler <jonas@bergler.name> 1611260784 -0800

Fix calculation of durations in UI

The logic in this method was using round resulting in some
durations rendering incorrectly - specifically > 30 secs, >30 mins,
>12 hours, etc

The behavior I saw prior to this change is as follows:

> start = new Date("2021-01-21 18:14:25.000000000")
: Date Thu Jan 21 2021 18:14:25 GMT+1300 (New Zealand Daylight Time)

> end = new Date("2021-01-21 18:44:35.000000000")
: Date Thu Jan 21 2021 18:44:35 GMT+1300 (New Zealand Daylight Time)

> generateDurationString(start, end)
: "1 hour 30 min"

After the change it is as follows:

> start = new Date("2021-01-21 18:14:25.000000000")
: Date Thu Jan 21 2021 18:14:25 GMT+1300 (New Zealand Daylight Time)

> end = new Date("2021-01-21 18:44:35.000000000")
: Date Thu Jan 21 2021 18:44:35 GMT+1300 (New Zealand Daylight Time)

> generateDurationString(start, end)
: "30 min 10 sec"

Change also adds additional test coverage for these cases.

Change-Id: Ie6d1d5b66a67b478000db49dc19525592f156120