)]}' { "commit": "8af457d3634e67e6e06ada4772c2f6fc40578692", "tree": "d0402fd3e7655b709428db219350d56e03e7e9b8", "parents": [ "0405ec0719d25ab6cfc02a825b6f0a8704b6578c" ], "author": { "name": "Thomas Draebing", "email": "thomas.draebing@sap.com", "time": "Wed Feb 06 17:39:21 2019 +0100" }, "committer": { "name": "Thomas Dräbing", "email": "thomas.draebing@sap.com", "time": "Mon Feb 11 15:22:40 2019 +0000" }, "message": "Fix conversion from AccessToken to OAuthToken\n\nThe login via UAA failed with \"Server Error\", when using the cfoauth\nplugin with Gerrit stable-2.16, because OAuthToken-constructor provided\nby the oauth extension of Gerrit does now require the \u0027secret\u0027- and the\n\u0027raw\u0027-parameter not to be null.\n\nThis change adds the raw response of the UAA server to the AccessToken\nobject, which is then handed to the OAuth extension point of Gerrit\ninstead of null.\n\nSince UAA uses OAuth 2.0, no token secret is used. Since the Gerrit\nOAuth extension point expects a token secret to be sent, an empty string\nwill be used instead. This follows the approach used by the scribe-java\nlibrary, which is used in the OAuth implementation of Gerrit and this\nplugin.\n\nChange-Id: I4e36b2a651951aff1cf08932b2902fa86905976e\n", "tree_diff": [ { "type": "modify", "old_id": "9ea32ed46fa86071a53e558136fd04ea9b826fca", "old_mode": 33188, "old_path": "src/main/java/com/googlesource/gerrit/plugins/cfoauth/AccessToken.java", "new_id": "56214d2c8dfc23542019ef991daa6acaf8f90631", "new_mode": 33188, "new_path": "src/main/java/com/googlesource/gerrit/plugins/cfoauth/AccessToken.java" }, { "type": "modify", "old_id": "b5b294e138bb50b495cdbee97c04d2a82d0ebbe7", "old_mode": 33188, "old_path": "src/main/java/com/googlesource/gerrit/plugins/cfoauth/CFOAuthService.java", "new_id": "a3d2b01e4d8416c2c782c0b5219ec9462c0f923d", "new_mode": 33188, "new_path": "src/main/java/com/googlesource/gerrit/plugins/cfoauth/CFOAuthService.java" }, { "type": "modify", "old_id": "fb670754469738b1b3f4295d06caa98861a1e973", "old_mode": 33188, "old_path": "src/main/java/com/googlesource/gerrit/plugins/cfoauth/UAAClient.java", "new_id": "9ff9dbb6772fbc614a12247203c950cf0b9d6a41", "new_mode": 33188, "new_path": "src/main/java/com/googlesource/gerrit/plugins/cfoauth/UAAClient.java" }, { "type": "modify", "old_id": "a9cf635c63dd888684cb3c18b8cb72dc681e9e6b", "old_mode": 33188, "old_path": "src/test/java/com/googlesource/gerrit/plugins/cfoauth/AccessTokenTest.java", "new_id": "f728916c1b89061224d6dbe45ad24f26d1a8d66c", "new_mode": 33188, "new_path": "src/test/java/com/googlesource/gerrit/plugins/cfoauth/AccessTokenTest.java" }, { "type": "modify", "old_id": "ab22c7736c170f169aa07d10092ebef3dac73e04", "old_mode": 33188, "old_path": "src/test/java/com/googlesource/gerrit/plugins/cfoauth/UAAClientTest.java", "new_id": "1d2ba1c38f33b5143f44f99654dbb2323711abdf", "new_mode": 33188, "new_path": "src/test/java/com/googlesource/gerrit/plugins/cfoauth/UAAClientTest.java" } ] }