commit e259ac2a2bbad16cf756374b7e57cbaf9c668fc5
author Patrick Georgi <pgeorgi@google.com> Sun Sep 15 17:21:40 2019 +0200
committer Patrick Georgi <pgeorgi@google.com> Tue Sep 24 12:01:23 2019 +0200
tree d372b8363300711715c672dc62f8759dcf01e4bf
parent f4d12d66094fd3262f49630d6ab5c46653cfacb6

Internalize strings

They have exactly one place where they're used.

Change-Id: If6206f15d0476e8f9df7645ce3e5da3e1f8e911c
Signed-off-by: Patrick Georgi <pgeorgi@google.com>

src/main/java/com/googlesource/gerrit/plugins/avatars/external/ExternalUrlAvatarProvider.java

diff --git a/src/main/java/com/googlesource/gerrit/plugins/avatars/external/ExternalUrlAvatarProvider.java b/src/main/java/com/googlesource/gerrit/plugins/avatars/external/ExternalUrlAvatarProvider.java
index ab0e36d..d178c9a 100644
--- a/src/main/java/com/googlesource/gerrit/plugins/avatars/external/ExternalUrlAvatarProvider.java
+++ b/src/main/java/com/googlesource/gerrit/plugins/avatars/external/ExternalUrlAvatarProvider.java
@@ -33,9 +33,6 @@
 @Singleton
 public class ExternalUrlAvatarProvider implements AvatarProvider {
 
-  private static final String USER_PLACEHOLDER = "${user}";
-  private static final String EMAIL_PLACEHOLDER = "${email}";
-
   private final String pluginName;
   private final boolean ssl;
   private String externalAvatarUrl;
@@ -131,9 +128,9 @@
    * @return filled in string
    */
   private String fillOutTemplate(String template, IdentifiedUser user) {
-    String workString = replaceInUrl(USER_PLACEHOLDER,
+    String workString = replaceInUrl("${user}",
         template, user.getUserName().orElse(null));
-    return replaceInUrl(EMAIL_PLACEHOLDER, workString,
+    return replaceInUrl("${email}", workString,
         user.getAccount().preferredEmail());
   }
 }