commit 1392233329f640cae1ff56293014f4ee1bc5ac3b
author David Pursehouse <dpursehouse@collab.net> Thu Sep 07 22:07:17 2017 +0900
committer David Pursehouse <dpursehouse@collab.net> Wed Sep 20 09:45:06 2017 +0900
tree 62b60c6f103a5bfb970aea1b6bd7b7391644bd19
parent d419821b3b9d1b1e68918aaba091fdae56768b43

Adapt to permission backend

Change-Id: I39fe14d7eb4c6def86e0364ae36003abf9f08770

src/main/java/com/criteo/gerrit/plugins/automerge/AtomicityHelper.java

diff --git a/src/main/java/com/criteo/gerrit/plugins/automerge/AtomicityHelper.java b/src/main/java/com/criteo/gerrit/plugins/automerge/AtomicityHelper.java
index ac70080..1f4b11a 100644
--- a/src/main/java/com/criteo/gerrit/plugins/automerge/AtomicityHelper.java
+++ b/src/main/java/com/criteo/gerrit/plugins/automerge/AtomicityHelper.java
@@ -1,8 +1,12 @@
 package com.criteo.gerrit.plugins.automerge;
 
+import static com.google.gerrit.server.permissions.ChangePermission.READ;
+
 import com.google.gerrit.common.data.SubmitRecord;
 import com.google.gerrit.extensions.api.changes.SubmitInput;
 import com.google.gerrit.extensions.common.ChangeInfo;
+import com.google.gerrit.extensions.restapi.AuthException;
+import com.google.gerrit.extensions.restapi.ResourceNotFoundException;
 import com.google.gerrit.reviewdb.client.Account;
 import com.google.gerrit.reviewdb.client.Change;
 import com.google.gerrit.reviewdb.client.Project;
@@ -19,7 +23,9 @@
 import com.google.gerrit.server.change.Submit;
 import com.google.gerrit.server.data.ChangeAttribute;
 import com.google.gerrit.server.git.MergeUtil;
-import com.google.gerrit.server.project.ChangeControl;
+import com.google.gerrit.server.notedb.ChangeNotes;
+import com.google.gerrit.server.permissions.PermissionBackend;
+import com.google.gerrit.server.permissions.PermissionBackendException;
 import com.google.gerrit.server.project.NoSuchChangeException;
 import com.google.gerrit.server.project.SubmitRuleEvaluator;
 import com.google.gerrit.server.query.change.ChangeData;
@@ -42,9 +48,6 @@
   ChangeData.Factory changeDataFactory;
 
   @Inject
-  private ChangeControl.GenericFactory changeFactory;
-
-  @Inject
   private ChangesCollection collection;
 
   @Inject
@@ -77,6 +80,12 @@
   @Inject
   Emails emails;
 
+  @Inject
+  ChangeNotes.Factory changeNotesFactory;
+
+  @Inject
+  PermissionBackend permissionBackend;
+
   /**
    * Check if the current patchset of the specified change has dependent
    * unmerged changes.
@@ -142,10 +151,20 @@
   }
 
   public RevisionResource getRevisionResource(String project, int changeNumber) throws NoSuchChangeException, OrmException {
-    ChangeControl ctl = changeFactory.validateFor(db.get(), new Change.Id(changeNumber), getBotUser());
-    ChangeData changeData = changeDataFactory.create(db.get(), new Project.NameKey(project), new Change.Id(changeNumber));
-    RevisionResource r = new RevisionResource(collection.parse(ctl), changeData.currentPatchSet());
-    return r;
+    Change.Id changeId = new Change.Id(changeNumber);
+    ChangeNotes notes = changeNotesFactory.createChecked(changeId);
+    try {
+      permissionBackend
+        .user(getBotUser())
+        .change(notes)
+        .database(db)
+        .check(READ);
+      ChangeData changeData = changeDataFactory.create(db.get(), new Project.NameKey(project), changeId);
+      RevisionResource r = new RevisionResource(collection.parse(changeId), changeData.currentPatchSet());
+      return r;
+    } catch (ResourceNotFoundException | AuthException | PermissionBackendException e) {
+      throw new NoSuchChangeException(changeId);
+    }
   }
 
   private IdentifiedUser getBotUser() {