tree f8718f0830691a75ce1d082efa1b7de984b36567
parent f12fd7f8e2bf5a511d0c501db8c927718f4bede3
author David Ostrovsky <david@ostrovsky.org> 1570313638 +0200
committer David Ostrovsky <david@ostrovsky.org> 1570357869 +0200

Bazel: Remove superfluous dependencies flagged by unused_deps

Bazel buildtools project includes in addition to buildifier also unused
deps and buildozer utilities, that detect unused dependencies and fix
them by applying the removal to the build files. This change is created
by installing unused_deps from buildtools@HEAD and running:

  $ unused_deps //...

and applying the suggested modifications.

One side effect of this clean up, is that some plugins might need to be
adapted. Particularly, j.c.g.g.server.audit:audit rule excessively added
unused dependencies, among other lucene, and the audit rule is included
in j.c.g.g.testing:gerrit-test-util rules and thus inherited by the core
and plugins testing code. The correct way to do it, is to add lucene as
runtime dependency instead.

Another side effect is that //prolog:gerrit-prolog-common is now removed
from j.c.g.g.httpd.init:init rule (as it is unused there). Given that
init rule is a root for gerrit.war gathering machinery, the prolof
predicates would be missing in the final build artifact. To rectify, add
prolog predicates in addition to the init rule to the gerrit.war
gathering machinery.

Change-Id: Ib3e6c218ffc6a85f31e8a1192cdd60c759cbd68e