Google Git
Sign in
gerrit / luci-config / 9d3b7c5184f607b3338727e2a600038050ba41c1
commit9d3b7c5184f607b3338727e2a600038050ba41c1[log] [tgz]
authorFrank Borden <frankborden@google.com>Thu May 04 13:10:48 2023 +0200
committerFrank Borden <frankborden@google.com>Thu May 04 13:10:48 2023 +0200
treecd0aa7047bfecd89594eca42db37028bf6cede51
parent7e4ddbdd6136e87977bc067029ded1b6eb64cd94 [diff]
Remove pending stanza from post-run action

Also execute main.star to actually apply the changes, I forgot this in
my previous change.

The post_actions are only triggered when the LUCI recipe terminates, so
it will never match the pending stanza. Unfortunately this means a rerun
on the same patchset will not reset the Frontend-Verified vote when the
new run starts.

Change-Id: Id080f6c773dbe31f63e634bcc7bdcd418864179e
2 files changed
tree: cd0aa7047bfecd89594eca42db37028bf6cede51
  1. generated/
  2. infra/
  3. recipes/
  4. repos/
  5. .gitignore
  6. main.star
  7. README.md
README.md

LUCI Configuration

This repo holds all the configuration for LUCI, the CI system Gerrit uses. You can find recent verification runs and logs at https://ci.chromium.org/ui/p/gerrit/builders.

Concepts

  • Recipe: a python script to verify a change, and a test for that verification
  • Builder: a recipe configured to run on a specific machine type
  • CQ Group: a watcher that triggers on new votes/patchsets on the specified repo+refs
  • CQ Tryjob Verifier: combines a CQ group with a builder to run a recipe when a new vote or patchset comes in

Layout

  • /main.star: overall starlark configuration for the entire host. It is also executable to generate the config data
  • /repos/*.star: repo-specific starlark configuration for builders, CQ groups, CQ tryjob verifiers, etc
  • /recipes/recipes/*.py: recipes for testing a change based on the repo
  • /recipes/recipes.py: executes recipe tests and compares/generates expected JSON goldens. 100% coverage is expected.
  • /recipes/recipe_modules/: dependencies shared by modules
  • /recipes/*.expected/*.json: expected commands executed by the recipe
  • /infra/config/recipes.cfg: versions and URLs of external recipe dependencies

Prerequisites

  • lucicfg - CLI tool to generate the configuration from the starlark scripts. To install, clone depot_tools.
  • python - Python 3, used to execute recipes.

Imporant commands

Regenerate config data after making changes (lucicfg):

$ ./main.star

Run recipe tests (python):

$ recipes/recipes.py test run

Update recipe test goldens (python):

$ recipes/recipes.py test train

Documentation