tree 07121dd413ae2c99e870e4af5dc6756864f235bb
parent 9b6c331d6f24db2d0faae016f801effb39a2de2f
author David Ostrovsky <david@ostrovsky.org> 1771570254 +0100
committer David Ostrovsky <david@ostrovsky.org> 1771571326 +0100

Add archive servlet integration test

In change Ic7dc1c8e96e an update of commons-compress from 1.25.0 to
1.28.0 was attempted as part of a broader WORKSPACE dependency refresh.

commons-compress 1.28.0 introduces a runtime dependency on
commons-io (via org.apache.commons.io.output.CountingOutputStream),
which is used by JGit's archive implementation
(org.eclipse.jgit.archive.TarFormat / TgzFormat) when writing
tar/tgz archives.

Gitiles' Bazel configuration does not automatically pull in Maven
transitive dependencies, so commons-io must be declared explicitly.
The attempted upgrade initially omitted this dependency, which would
have caused runtime failures when serving archive downloads, e.g.:

  /<repo>/+archive/refs/heads/<ref>.tar.gz

resulting in:

  java.lang.NoClassDefFoundError:
    org/apache/commons/io/output/CountingOutputStream

This issue was identified during code review and corrected before
submission, but the existing test suite did not exercise the archive
servlet code path and therefore did not detect the breakage.

Add a servlet-level integration test for the archive endpoint that:

* creates a small in-memory test repository
* requests a .tar.gz archive via GitilesServlet
* verifies HTTP 200 response
* verifies response body is non-empty

This test executes ArchiveCommand.call() end-to-end and will fail
with NoClassDefFoundError if commons-io is missing from the runtime
classpath, preventing similar dependency regressions in future
dependency updates.

Change-Id: Ia9266aa6a6ca63b119e2216d8376ce0382ae6e44