commit b9061269bf4c6a0fc391150c102cd35f12fee89b
author David Pursehouse <dpursehouse@collab.net> Mon May 13 06:52:07 2019 +0200
committer David Pursehouse <dpursehouse@collab.net> Mon May 13 06:59:54 2019 +0200
tree d4a63ba18f8c407b86014a63b74703ad598075c9
parent 6dec837d8af8e2fdeb3ca2004f71e0d3b812814b

Remove unnecessarily nested else blocks

Change-Id: I5870988e30078fbe2b184980683593005b0d7147

java/com/google/gitiles/RevisionServlet.java

diff --git a/java/com/google/gitiles/RevisionServlet.java b/java/com/google/gitiles/RevisionServlet.java
index e46d25b..38aecb6 100644
--- a/java/com/google/gitiles/RevisionServlet.java
+++ b/java/com/google/gitiles/RevisionServlet.java
@@ -151,12 +151,11 @@
       ObjectLoader loader = reader.open(view.getRevision().getId());
       if (loader.getType() != OBJ_COMMIT) {
         throw new GitilesRequestFailureException(FailureReason.UNSUPPORTED_OBJECT_TYPE);
-      } else {
-        PathServlet.setTypeHeader(res, loader.getType());
-        try (Writer writer = startRenderText(req, res);
-            OutputStream out = BaseEncoding.base64().encodingStream(writer)) {
-          loader.copyTo(out);
-        }
+      }
+      PathServlet.setTypeHeader(res, loader.getType());
+      try (Writer writer = startRenderText(req, res);
+          OutputStream out = BaseEncoding.base64().encodingStream(writer)) {
+        loader.copyTo(out);
       }
     }
   }

java/com/google/gitiles/doc/DocServlet.java

diff --git a/java/com/google/gitiles/doc/DocServlet.java b/java/com/google/gitiles/doc/DocServlet.java
index 09c02de..ca83ae0 100644
--- a/java/com/google/gitiles/doc/DocServlet.java
+++ b/java/com/google/gitiles/doc/DocServlet.java
@@ -270,9 +270,8 @@
   private static void fileTooBig(HttpServletResponse res, GitilesView view) throws IOException {
     if (view.getType() == GitilesView.Type.ROOTED_DOC) {
       throw new GitilesRequestFailureException(FailureReason.OBJECT_TOO_LARGE);
-    } else {
-      res.sendRedirect(GitilesView.show().copyFrom(view).toUrl());
     }
+    res.sendRedirect(GitilesView.show().copyFrom(view).toUrl());
   }
 
   private static class MarkdownFile {