tree 5e3267b5083619fe83afdb4fd0ac61bb314a5343
parent d0d8cebd0b199996d54b10791c254a8bd03a8a9f
author Luke Sandberg <lukes@google.com> 1513969715 -0800
committer Jonathan Nieder <jrn@google.com> 1515091052 -0800

Change all foreach loops in Soy templates to use for loop syntax

Soy supports 2 kinds of loops:
 * foreach- for iterating over items in a collection,
   e.g. {foreach $item in $list}...{/foreach}
 * for - for indexed iteration,
   e.g. {for $i in range(0, 10)}...{/for}

The reason Soy has 2 different loops is an accident of history, Soy
didn’t use to have a proper grammar for expressions and so the alternate
'for...range' syntax was added to make it possible to write indexed
loops. As the grammar has improved having the two syntaxes is no longer
necessary and so we are eliminating one of them.

As of [1] or mvn release "2018-01-03" the two forms are actually aliases
for one another, so the only difference is the keyword ('for' vs
'foreach'), and while the foreach loop is more popular the 'for'
terminology is more standard so upstream recommends switching everything
to that.

[1] https://github.com/google/closure-templates/commit/4a7373333fee6c22784b48e29825b9cea3ffaae7

PiperOrigin-RevId: 180807358
Change-Id: I22fe13baffae5567d0e123395a62f2d837ea374c