tree 5eb2f1135ad2f95dc73c708f84a0a897c25038db
parent 55240365404a0f503297b0bad1cece6c17f94fb6
author Luca Milanesio <luca.milanesio@gmail.com> 1574108078 -0800
committer David Pursehouse <dpursehouse@collab.net> 1574907695 +0900

Check BLOB content size before trying to render it

Make sure that the content returned by JGit is below the
maximum size allowed for formatting/rendering with Soy.

The method loader.getCachedBytes(MAX_FILE_SIZE) would
return an in-memory content larger than MAX_FILE_SIZE if
the the BLOB is smaller than streamFileThreshold.

Parsing 100s megabytes of in-memory content using a
prettyfier regex and trying to render it in HTML would
result in a massive allocation of strings in the JVM heap.
The overload of memory allocation may eventually result in
triggering continuous 'stop-the-world' GC cycles, blocking
the process for several minutes.

Bug: https://github.com/google/gitiles/issues/192
Change-Id: I6ab5f367e731d67d4a5816a0beae5551106bb72b