commit 55a49f46d8517e7a1a752e48351d028027466292
author David Pursehouse <dpursehouse@collab.net> Tue Jul 03 14:10:11 2018 +0900
committer David Pursehouse <dpursehouse@collab.net> Wed Jul 25 09:59:42 2018 +0100
tree 9311bd3a4f78695de653ededbd4d1df95f365563
parent a750e870f085f7f04b684ffb3602f1c22f64da61

RefServlet: Fix usage of deprecated RefDatabase#getRefs(String)

Change-Id: I088ef4480f431b0d971669177eefdbc9a41c5553

java/com/google/gitiles/RefServlet.java

diff --git a/java/com/google/gitiles/RefServlet.java b/java/com/google/gitiles/RefServlet.java
index d40962b..8434c86 100644
--- a/java/com/google/gitiles/RefServlet.java
+++ b/java/com/google/gitiles/RefServlet.java
@@ -14,9 +14,11 @@
 
 package com.google.gitiles;
 
+import static com.google.common.base.Preconditions.checkArgument;
 import static com.google.common.base.Preconditions.checkNotNull;
 import static javax.servlet.http.HttpServletResponse.SC_NOT_FOUND;
 
+import com.google.common.collect.ImmutableList;
 import com.google.common.collect.ImmutableMap;
 import com.google.common.collect.Lists;
 import com.google.common.collect.Maps;
@@ -74,22 +76,21 @@
   @Override
   protected void doGetText(HttpServletRequest req, HttpServletResponse res) throws IOException {
     GitilesView view = ViewFilter.getView(req);
-    Map<String, Ref> refs =
-        getRefs(ServletUtils.getRepository(req).getRefDatabase(), view.getPathPart());
+    RefsResult refs = getRefs(ServletUtils.getRepository(req).getRefDatabase(), view.getPathPart());
     TextRefAdvertiser adv = new TextRefAdvertiser(startRenderText(req, res));
     adv.setDerefTags(true);
-    adv.send(refs);
+    adv.send(refs.refs);
     adv.end();
   }
 
   @Override
   protected void doGetJson(HttpServletRequest req, HttpServletResponse res) throws IOException {
     GitilesView view = ViewFilter.getView(req);
-    Map<String, Ref> refs =
-        getRefs(ServletUtils.getRepository(req).getRefDatabase(), view.getPathPart());
+    RefsResult refs = getRefs(ServletUtils.getRepository(req).getRefDatabase(), view.getPathPart());
     Map<String, RefJsonData> jsonRefs = new LinkedHashMap<>();
-    for (Map.Entry<String, Ref> ref : refs.entrySet()) {
-      jsonRefs.put(ref.getKey(), new RefJsonData(ref.getValue()));
+    int prefixLen = refs.prefix.length();
+    for (Ref ref : refs.refs) {
+      jsonRefs.put(ref.getName().substring(prefixLen), new RefJsonData(ref));
     }
     renderJson(req, res, jsonRefs, new TypeToken<Map<String, RefJsonData>>() {}.getType());
   }
@@ -161,7 +162,8 @@
       @Nullable Ref headLeaf,
       int limit)
       throws IOException {
-    Collection<Ref> refs = refdb.getRefs(prefix).values();
+    checkArgument(prefix.endsWith("/"), "ref hierarchy prefix should end with /: %s", prefix);
+    Collection<Ref> refs = refdb.getRefsByPrefix(prefix);
     refs = ordering.leastOf(refs, limit > 0 ? Ints.saturatedCast(limit + 1L) : refs.size());
     List<Map<String, Object>> result = Lists.newArrayListWithCapacity(refs.size());
 
@@ -192,17 +194,28 @@
     return refName.replace("&", "&amp;").replace("<", "&lt;").replace(">", "&gt;");
   }
 
-  private static Map<String, Ref> getRefs(RefDatabase refdb, String path) throws IOException {
+  private static class RefsResult {
+    String prefix;
+    List<Ref> refs;
+
+    RefsResult(String prefix, List<Ref> refs) {
+      this.prefix = prefix;
+      this.refs = refs;
+    }
+  }
+
+  private static RefsResult getRefs(RefDatabase refdb, String path) throws IOException {
     path = GitilesView.maybeTrimLeadingAndTrailingSlash(path);
     if (path.isEmpty()) {
-      return refdb.getRefs(RefDatabase.ALL);
+      return new RefsResult(path, refdb.getRefs());
     }
     path = Constants.R_REFS + path;
     Ref singleRef = refdb.exactRef(path);
     if (singleRef != null) {
-      return ImmutableMap.of(singleRef.getName(), singleRef);
+      return new RefsResult(path, ImmutableList.of(singleRef));
     }
-    return refdb.getRefs(path + '/');
+    path = path + '/';
+    return new RefsResult(path, refdb.getRefsByPrefix(path));
   }
 
   private static class TextRefAdvertiser extends RefAdvertiser {