tree b77a2973a02c1217522326c523af4d748b9bc41d
parent 5137fbbfb31bc7f8b9b7243934d3c80e558a277c
author Achim Thesmann <achim@google.com> 1783620840 +0000
committer gerrit-scoped@luci-project-accounts.iam.gserviceaccount.com <gerrit-scoped@luci-project-accounts.iam.gserviceaccount.com> 1783965835 -0700

hooks: enhance Change-Id check to catch case-insensitive duplicates

Update check_commit_msg_changeid_field to check for multiple Change-Id
footers in a case-insensitive manner (including variations like
Change-ID or change-id), and explicitly reject non-matching cases or
malformed value formats.

Previously, casing and format checks were coupled, causing malformed ID
values (such as a missing 'I' prefix) to be falsely reported as field
casing errors. This change decouples field name casing validation from
value format validation into independent checks with actionable error
messages, and ensures that duplicate Change-Id footers trigger an
explicit rejection even when mixed casing or format errors are present.

Also replaces the single batch unit test with 7 focused test methods
covering valid messages, casing errors, format errors, duplicate lines,
and mixed combinations.

Bug: 533035135
Test: python3 -m unittest rh/hooks_unittest.py
Test: tried to upload change with duplicate change-id
Change-Id: I9ab168a3d99f7b6cd3f9200c2c2c389e9163525d
Reviewed-on: https://gerrit-review.googlesource.com/c/git-repohooks/+/605723
Reviewed-by: Mike Frysinger <vapier@google.com>
Commit-Queue: Achim Thesmann <achim@google.com>
Tested-by: Achim Thesmann <achim@google.com>