Allow quotes in editor command on Windows
This change allows setting the EDITOR env. variable to point to a
program location that contains quotes and spaces.
For example:
> set EDITOR="C:\Program Files (x86)\Notepad++\notepad++.exe" -multiInst -nosession
> repo upload
Change-Id: Ic95b00f7443982b1956a2992d0220e50b1cf6bbb
diff --git a/editor.py b/editor.py
index 96d7ce4..7980f2b 100644
--- a/editor.py
+++ b/editor.py
@@ -83,7 +83,12 @@
os.close(fd)
fd = None
- if re.compile("^.*[$ \t'].*$").match(editor):
+ if platform_utils.isWindows():
+ # Split on spaces, respecting quoted strings
+ import shlex
+ args = shlex.split(editor)
+ shell = False
+ elif re.compile("^.*[$ \t'].*$").match(editor):
args = [editor + ' "$@"', 'sh']
shell = True
else:
