fetch: Fix stderr handling for gsutil

Previously gsutil stderr was getting piped into stdout, which
yields bad results if there are non-fatal warnings in stderr.

Additionally, we should fail outright if gsutil fails (by adding
`check = True`) rather than fail later on when we try to sync to
a manifest that is in fact just a stderr dump.

TEST=manual runs with bad gs urls

Change-Id: Id71791d0c3f180bd0601ef2c783a8e8e4afa8f59
Reviewed-on: https://gerrit-review.googlesource.com/c/git-repo/+/321935
Tested-by: Jack Neus <jackneus@google.com>
Reviewed-by: Mike Frysinger <vapier@google.com>
2 files changed
tree: 2c7f8e448acb0881397f97a71e205b613aa747e5
  1. .github/
  2. docs/
  3. hooks/
  4. man/
  5. release/
  6. subcmds/
  7. tests/
  8. .flake8
  9. .gitattributes
  10. .gitignore
  11. .mailmap
  12. .project
  13. .pydevproject
  14. color.py
  15. command.py
  16. completion.bash
  17. editor.py
  18. error.py
  19. event_log.py
  20. fetch.py
  21. git_command.py
  22. git_config.py
  23. git_refs.py
  24. git_ssh
  25. git_superproject.py
  26. git_trace2_event_log.py
  27. gitc_utils.py
  28. hooks.py
  30. main.py
  31. MANIFEST.in
  32. manifest_xml.py
  33. pager.py
  34. platform_utils.py
  35. platform_utils_win32.py
  36. progress.py
  37. project.py
  38. README.md
  39. repo
  40. repo_trace.py
  41. requirements.json
  42. run_tests
  43. setup.py
  44. ssh.py
  46. tox.ini
  47. wrapper.py


Repo is a tool built on top of Git. Repo helps manage many Git repositories, does the uploads to revision control systems, and automates parts of the development workflow. Repo is not meant to replace Git, only to make it easier to work with Git. The repo command is an executable Python script that you can put anywhere in your path.


Please use the repo-discuss mailing list or issue tracker for questions.

You can file a new bug report under the “repo” component.

Please do not e-mail individual developers for support. They do not have the bandwidth for it, and often times questions have already been asked on repo-discuss or bugs posted to the issue tracker. So please search those sites first.


Many distros include repo, so you might be able to install from there.

# Debian/Ubuntu.
$ sudo apt-get install repo

# Gentoo.
$ sudo emerge dev-vcs/repo

You can install it manually as well as it's a single script.

$ mkdir -p ~/.bin
$ PATH="${HOME}/.bin:${PATH}"
$ curl https://storage.googleapis.com/git-repo-downloads/repo > ~/.bin/repo
$ chmod a+rx ~/.bin/repo