| commit | 2afce52141f7495d6867a9aeb0bcbd0c7494288f | [log] [tgz] |
|---|---|---|
| author | David Ostrovsky <david@ostrovsky.org> | Sat Jan 05 17:04:59 2019 +0100 |
| committer | David Pursehouse <dpursehouse@collab.net> | Fri Jan 11 08:36:00 2019 +0900 |
| tree | 3a55b7274be204b09bed0d64cd572137746a0109 | |
| parent | 0b61aa0aa19afe84b83766572cda46f6cb529dd8 [diff] |
Revert "Fix the missing DB entry in Gerrit DB" This reverts commit fcc90699fdec17b941a473221d228c832a533fc0. Reason for revert: Security vulnerability for OAuth and OpenID auth schemes. OAuth and OpenID authentication schemes support multiple identity providers, e.g.: CAS-OAuth2 and GitHub-OAuth2. An attacker can easily impersonate existing Gerrit user by creating account on a different provider with exactly the same username as the existing Gerrit account. Instead of creating a fresh new user, the new account is erroneously linked to the existing Gerrit account, even though, account linking feature was not triggered from the Gerrit UI. The original commit tried to fix intermittent database corruption problem, with missing record in the database, in the context of single identity provider (LDAP) where such problem doesn't exist, as there is no way that one single username can belong to physical different users. Nevertheless, there should be found another workaround, as trying to recover on the fly and introducing severe security breach for other auth schemes supported in Gerrit. If all else fails, the missing database record has to be inserted manually and the corresponding account must be re-indexed. Bug: Issue 7652 Bug: Issue 10242 Change-Id: Icba3452c153b2ae3cc1a4ebc569342641f38c07c
Gerrit is a code review and project management tool for Git based projects.
Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.
For information about how to install and use Gerrit, refer to the documentation.
Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.
Please report bugs on the issue tracker.
Gerrit is the work of hundreds of contributors. We appreciate your help!
Please read the contribution guidelines.
Note that we do not accept Pull Requests via the Github mirror.
The IRC channel on freenode is #gerrit. An archive is available at: echelog.com.
The Developer Mailing list is repo-discuss on Google Groups.
Gerrit is provided under the Apache License 2.0.
Install Bazel and run the following:
git clone --recursive https://gerrit.googlesource.com/gerrit
cd gerrit && bazel build release
The instruction how to configure GerritForge/BinTray repositories is here
On Debian/Ubuntu run:
apt-get update & apt-get install gerrit=<version>-<release>
NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.
On CentOS/RedHat run:
yum clean all && yum install gerrit-<version>[-<release>]
On Fedora run:
dnf clean all && dnf install gerrit-<version>[-<release>]
Docker images of Gerrit are available on DockerHub
To run a CentOS 7 based Gerrit image:
docker run -p 8080:8080 gerritforge/gerrit-centos7[:version]
To run a Ubuntu 15.04 based Gerrit image:
docker run -p 8080:8080 gerritforge/gerrit-ubuntu15.04[:version]
NOTE: release is optional. Last released package of the version is installed if the release number is omitted.