)]}' { "commit": "43fe972939560029f5918bd50ad3e3e287c48620", "tree": "3daf94f6ef7ea1b157baa35de951fda6603c66f2", "parents": [ "a09e97bfba8d4ad1167f89ab7ed07c060a74d70e" ], "author": { "name": "Edwin Kempin", "email": "ekempin@google.com", "time": "Mon Dec 19 18:06:00 2016 +0100" }, "committer": { "name": "David Pursehouse", "email": "dpursehouse@collab.net", "time": "Tue Feb 21 23:35:39 2017 +0000" }, "message": "Don\u0027t require Add Patch Set permission for submit by rebase\n\nWhen the submit strategy was Rebase Always or Rebase If Necessary and\na rebase was needed for the submit, the submit failed if the user\ndidn\u0027t have the Add Patch Set permission. However for submitting a\nchange the Submit permission alone should be sufficient.\n\nThe behavior is now consistent with the Cherry-Pick submit strategy\nwhich also doesn\u0027t require the Add Patch Set permission if a\ncherry-pick is done on submit.\n\nChange-Id: Id9c484ff51f9dfa7ea77216fbf9b06a799676412\nSigned-off-by: Edwin Kempin \u003cekempin@google.com\u003e\n(cherry picked from commit 969a1953cf3889baa663fe59e421ba9cffcbabe3)\n", "tree_diff": [ { "type": "modify", "old_id": "6d7a66584e85865df36166ffd2bc579f43379f68", "old_mode": 33188, "old_path": "gerrit-acceptance-tests/src/test/java/com/google/gerrit/acceptance/rest/change/AbstractSubmit.java", "new_id": "8ab7c2a13fd4236d2d5fdb44a7a837a88eccbcec", "new_mode": 33188, "new_path": "gerrit-acceptance-tests/src/test/java/com/google/gerrit/acceptance/rest/change/AbstractSubmit.java" }, { "type": "modify", "old_id": "9b3fd15e178b84420fd5fdbea52eb2906bfab53a", "old_mode": 33188, "old_path": "gerrit-acceptance-tests/src/test/java/com/google/gerrit/acceptance/rest/change/SubmitByRebaseIfNecessaryIT.java", "new_id": "aa5386f2a17ae5c216db759e5d58951a4dfb1cfa", "new_mode": 33188, "new_path": "gerrit-acceptance-tests/src/test/java/com/google/gerrit/acceptance/rest/change/SubmitByRebaseIfNecessaryIT.java" }, { "type": "modify", "old_id": "5bc3a362b77aa63a4758c6742f2709de9a00b6d0", "old_mode": 33188, "old_path": "gerrit-server/src/main/java/com/google/gerrit/server/change/PatchSetInserter.java", "new_id": "f41d41d12e669f86867323c0275169961c015391", "new_mode": 33188, "new_path": "gerrit-server/src/main/java/com/google/gerrit/server/change/PatchSetInserter.java" }, { "type": "modify", "old_id": "8909e609c647340c9e9c394083e5c6c544fd1194", "old_mode": 33188, "old_path": "gerrit-server/src/main/java/com/google/gerrit/server/change/RebaseChangeOp.java", "new_id": "20dbfb335eff201239b609929091ccaa7d243b76", "new_mode": 33188, "new_path": "gerrit-server/src/main/java/com/google/gerrit/server/change/RebaseChangeOp.java" }, { "type": "modify", "old_id": "a309e6ec895266c4a23abe86203ab70fc6e57b63", "old_mode": 33188, "old_path": "gerrit-server/src/main/java/com/google/gerrit/server/git/strategy/RebaseIfNecessary.java", "new_id": "7892a4ac5ed44643ebbd8899f3c779a3c89df4a1", "new_mode": 33188, "new_path": "gerrit-server/src/main/java/com/google/gerrit/server/git/strategy/RebaseIfNecessary.java" } ] }