commit eeae64d051d635644af151da81ac1e0caa72cb9f
author Marco Miller <marco.miller@ericsson.com> Mon May 13 06:09:13 2019 -0400
committer Marco Miller <marco.miller@ericsson.com> Wed May 15 05:06:33 2019 -0400
tree a8b49d5651c1f6fdb8187ebf555986343cc43f13
parent 3b7ee91ff4267b12dc61d13fe06522f9910a2e13

ChangeQueryBuilder: Fix empty file extension case for Elasticsearch

Introduce a new FileWithNoExtensionPredicate class, which is a
PostFilterPredicate, used solely in an empty file extension case with
Elasticsearch. This post-filter predicate is then used at an extra cost.

Base this on the field-injected server configuration, as the constructor
alternative implies changing too many callers, mostly up-stack (and
rather unrelated) ones. This is because the current design is not meant
for such index type-specific behavior. However there will be follow-up
work to potentially replace this solution with the index type being
added to arguments' IndexConfig auto-building.

This previously broken behavior is being fixed this way for
Elasticsearch, while Lucene worked without failing these tests. This is
because Elasticsearch omits the file extension field when it holds an
empty value, from the document or source, whereas Lucene doesn't. There
is currently no other known way of solving this; there could be some.

Also assert the case of a change with only files that have no extension.
This added test case is necessary to fully prove this fix, alongside the
already covered case of a change with both extension-equipped files and
files with no extension.

Bug: Issue 10854
Change-Id: Iaa452e5b281a1ed48b06ca126eddb4a5b4384f26