tree 82927897362bcdb6a76ee797a07a09ea1c24e82f
parent 78c978e40741fdbd5103449a14a5b60614d6fcff
author Shawn Pearce <sop@google.com> 1376413164 -0700
committer Shawn Pearce <sop@google.com> 1376507566 -0700

Fix browser NPE when ChangeCache is incomplete

The ChangeCache is buggy and does not always populate its
contents. Unfortunately it is also designed to be unable to
load missing contents on demand, causing consumers to NPE.
ConfigInfoCache is a better design for this sort of lazy
loading and reuse of data.

ChangeCache can be missing information if:

  1) opens side-by-side view in a new tab;
  2) user presses 'r' to open publish comment screen

Instead of using the unreliable ChangeCache, stub out a
ChangeDetail to feed to the info block on the publish
comments screen.

Bug: issue 2039
Change-Id: Id542528d93af1cab49b001ca5e90addfc5d05b78
(cherry picked from commit f646aa77fb67b73c8724d7a632cafd441365e901)