)]}' { "commit": "223fc1ae91195e4eb1451be5d718014dceae485f", "tree": "2d2fac0ecac8e9240c9cc1e14befea53db537028", "parents": [ "d6296556c6838754477d972e2fbbc2227a2bbb33" ], "author": { "name": "Shawn O. Pearce", "email": "sop@google.com", "time": "Sun May 15 14:33:08 2011 -0700" }, "committer": { "name": "Shawn O. Pearce", "email": "sop@google.com", "time": "Sun May 15 14:38:23 2011 -0700" }, "message": "Reject invalid Change-Id lines\n\nEGit stores a placeholder \"Change-Id: I0000...\" line in the commit\nmessage when first setting up a commit. If there is a bug in EGit it\nmight fail to replace this line, causing the user to upload a commit\nto Gerrit with this placeholder Change-Id. Since the id is supposed to\nbe unique within a project, this upload will work at most once on a\nserver/project pair before it starts to cause problems for other users\non the same system. Check for this case and reject it when it occurs.\n\nWhen creating a new change, validate that the selected Change-Id line\nconforms to the I$commit_sha1 format that should be used. In the\nseveral years that we have been using Change-Id lines, nobody has\nfound a reason to use a different line format unless they have a\nbroken client that has created an invalid line.\n\nChange-Id: I64a46c0323b5e550e1415c8dfcf36ba2048820e1\nSigned-off-by: Shawn O. Pearce \u003csop@google.com\u003e\n", "tree_diff": [ { "type": "modify", "old_id": "b9045bc767cdd64ef4f16481300567e5b6aaf7ab", "old_mode": 33188, "old_path": "gerrit-server/src/main/java/com/google/gerrit/server/git/ReceiveCommits.java", "new_id": "ace7aeeb3f29b957b37703ae4308e2244a359384", "new_mode": 33188, "new_path": "gerrit-server/src/main/java/com/google/gerrit/server/git/ReceiveCommits.java" } ] }