Google Git
Sign in
gerrit / gerrit / f301e4529a09b194a9e115894ec09d8fd1449105
commitf301e4529a09b194a9e115894ec09d8fd1449105[log] [tgz]
authorPatrick Hiesel <hiesel@google.com>Wed Jul 21 14:19:38 2021 +0200
committerPatrick Hiesel <hiesel@google.com>Thu Jul 29 10:55:20 2021 +0200
tree5d38fd08e28d78b2a16cca37dc41bae87d22548d
parent6117cd3cd25b84ac530e142a3db026168424bd72 [diff]
LabelTypes: Return an Optional to make clear that value can be absent

When asking LabelTypes for a LabelType by name or ID, that LabelType
is only returned if the project has a label with name or ID
configured.

Most places in Gerrit correctly handled this implicit behavior, but
new code for SubmitRequirements (ChangeField:getMaxMinAnyLabels) did
not which made it fail with a NullPointerException in case a label
that was voted on the change was removed from project.config
since the vote was granted.

In this commit, we fix the NPE by reworking LabelTypes to return
an Optional which also makes it so that this programmer error
can't occur in the future.

Change-Id: I9e0f3a940ce21ef1e46b3dbb1675267ae1d76459
23 files changed
tree: 5d38fd08e28d78b2a16cca37dc41bae87d22548d
  1. .settings/
  2. .ts-out/
  3. antlr3/
  4. contrib/
  5. Documentation/
  6. e2e-tests/
  7. java/
  8. javatests/
  9. lib/
  10. modules/
  11. plugins/
  12. polygerrit-ui/
  13. prolog/
  14. prologtests/
  15. proto/
  16. resources/
  17. tools/
  18. webapp/
  19. polymer-bridges
  20. .bazelignore
  21. .bazelproject
  22. .bazelrc
  23. .bazelversion
  24. .editorconfig
  25. .git-blame-ignore-revs
  26. .gitignore
  27. .gitmodules
  28. .gitreview
  29. .mailmap
  30. .pydevproject
  31. .zuul.yaml
  32. BUILD
  33. COPYING
  34. INSTALL
  35. Jenkinsfile
  36. package.json
  37. README.md
  38. SUBMITTING_PATCHES
  39. twinkie.patch
  40. version.bzl
  41. WORKSPACE
  42. yarn.lock
README.md

Gerrit Code Review

Gerrit is a code review and project management tool for Git based projects.

Build Status Maven Central

Objective

Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.

Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.

Documentation

For information about how to install and use Gerrit, refer to the documentation.

Source

Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.

Reporting bugs

Please report bugs on the issue tracker.

Contribute

Gerrit is the work of hundreds of contributors. We appreciate your help!

Please read the contribution guidelines.

Note that we do not accept Pull Requests via the Github mirror.

Getting in contact

The Developer Mailing list is repo-discuss on Google Groups.

License

Gerrit is provided under the Apache License 2.0.

Build

Install Bazel and run the following:

    git clone --recurse-submodules https://gerrit.googlesource.com/gerrit
    cd gerrit && bazel build release

Install binary packages (Deb/Rpm)

The instruction how to configure GerritForge/BinTray repositories is here

On Debian/Ubuntu run:

    apt-get update & apt-get install gerrit=<version>-<release>

NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.

On CentOS/RedHat run:

    yum clean all && yum install gerrit-<version>[-<release>]

On Fedora run:

    dnf clean all && dnf install gerrit-<version>[-<release>]

Use pre-built Gerrit images on Docker

Docker images of Gerrit are available on DockerHub

To run a CentOS 8 based Gerrit image:

    docker run -p 8080:8080 gerritcodereview/gerrit[:version]-centos8

To run a Ubuntu 20.04 based Gerrit image:

    docker run -p 8080:8080 gerritcodereview/gerrit[:version]-ubuntu20

NOTE: release is optional. Last released package of the version is installed if the release number is omitted.