commit | c0d48abd75dc7bc8213af240b5057450891643ec | [log] [tgz] |
---|---|---|
author | Ben Rohlfs <brohlfs@google.com> | Wed Dec 01 13:01:04 2021 +0100 |
committer | Ben Rohlfs <brohlfs@google.com> | Wed Dec 01 17:59:17 2021 +0100 |
tree | a41febfaa84d08b48e358ab90b65201beda1cbe4 | |
parent | 9ac8727ad2fb59d0981bde081770bd3b9a9bf15e [diff] |
Fix auto-saving of new comment threads <gr-diff-host> has a sophisticated `_threadsChanged()` method that is called whenever there is a small change to the comments-model. It carefully compares thread objects from the model with the existing DOM elements for these, and creates, updates or removes elements as necessary. Since auto-saving of comments was implemented this detection logic was missing the ability to match the new saved thread object from the model with the existing "unsaved" DOM element that had triggered the auto-save, because there is no rootId to match. We are adding some logic for matching up the newly saved threads with the unsaved elements. We are also making sure that <gr-diff-host> never removes any unsaved comments that are currently being edited. Change-Id: I0a31dad3f2f55c6c18b8dccc775cb28dfd2e3b42
Gerrit is a code review and project management tool for Git based projects.
Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.
For information about how to install and use Gerrit, refer to the documentation.
Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.
Please report bugs on the issue tracker.
Gerrit is the work of hundreds of contributors. We appreciate your help!
Please read the contribution guidelines.
Note that we do not accept Pull Requests via the Github mirror.
The Developer Mailing list is repo-discuss on Google Groups.
Gerrit is provided under the Apache License 2.0.
Install Bazel and run the following:
git clone --recurse-submodules https://gerrit.googlesource.com/gerrit cd gerrit && bazel build release
The instruction how to configure GerritForge/BinTray repositories is here
On Debian/Ubuntu run:
apt-get update & apt-get install gerrit=<version>-<release>
NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.
On CentOS/RedHat run:
yum clean all && yum install gerrit-<version>[-<release>]
On Fedora run:
dnf clean all && dnf install gerrit-<version>[-<release>]
Docker images of Gerrit are available on DockerHub
To run a CentOS 8 based Gerrit image:
docker run -p 8080:8080 gerritcodereview/gerrit[:version]-centos8
To run a Ubuntu 20.04 based Gerrit image:
docker run -p 8080:8080 gerritcodereview/gerrit[:version]-ubuntu20
NOTE: release is optional. Last released package of the version is installed if the release number is omitted.