tree bc92b593b1df02913140a52f4a5afa973f52be66
parent ea9292caa67c13a48c8d69ce4a7fbd43bf790502
author Youssef Elghareeb <ghareeb@google.com> 1682524953 +0200
committer Youssef Elghareeb <ghareeb@google.com> 1683104459 +0200

Add option to populate 'starred' field for change query requests

We've recently moved the drafts and stars out of the change index (see
change I36c1e2f5) after which the returned ChangeInfo(s) from the 'Query
Changes' API always had the 'starred' field as null, since this field
is no longer populated from the change index.

We discovered this bug since the dashboard's data is populated from the
change index. To reproduce:
1) Go to dashboard and star a change (press the star icon).
2) Refresh the page. The star is gone.

Navigating to the change page after starring from dashboard shows the
star icon correctly in the change page. This is because the change page
is powered by the 'Get Change Detail' endpoint which does not use the
index.

To fix this, we add a change option to populate this field. This is done
by opening the All-Users repo once, and doing a call to
RefDatabase#exactRef(String... refs). Calls to #exactRef take
microseconds, and since this operation is gated with a list change
option (to be used by the gerrit dashboard), this operation should be
performant.

Google-Bug-Id: b/276296940
Release-Notes: Add option to populate 'starred' field for change queries
Change-Id: Idc0cac3e3aa715d18ddc1696d7324d13bcf84ce1