commit | f0b875b29ef2ebc06650cd98620abfb78c4c2660 | [log] [tgz] |
---|---|---|
author | Jacek Centkowski <geminica.programs@gmail.com> | Tue May 10 14:22:38 2022 +0100 |
committer | David Ostrovsky <david@ostrovsky.org> | Fri May 20 14:38:12 2022 +0200 |
tree | a93ca3ebbf5c3b3b7b5c9e17e6135595bfee89cf | |
parent | bd02a4223e5bdaaf14cab3a0c57e18c7dfdb7a4c [diff] |
Introduce general purpose Optional JSON serializer for GSON In the current version GSON has no dedicated implementation for Optional (more context given in [1]) type and uses reflection in order to (de)serialize it. The problem is that newer versions of JDK (for instance 17) no longer allow for JDK internal classes reflection access. One option to solve it is to pass arg to VM ('--add-opens java.base/java.util=ALL-UNNAMED') but that gets flaky as more tests are written and option keeps getting propagated to more packages and what is more it is not a solution for long term. This change solves it by adding a general purpose Optional (de)serializer that gets registered prior to the specific ones and doesn't rely on reflection. The (de)serialization of this adapter is exactly the same as the reflective (de)serialization. [1] https://github.com/google/gson/pull/2022 Release-Notes: Introduce non-reflection based Optional Type Adapter Bug: Issue 15504 Change-Id: I64b553f2a8c14ce1c83fbac8edfeeb3e6aa2c2cf
Gerrit is a code review and project management tool for Git based projects.
Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.
For information about how to install and use Gerrit, refer to the documentation.
Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.
Please report bugs on the issue tracker.
Gerrit is the work of hundreds of contributors. We appreciate your help!
Please read the contribution guidelines.
Note that we do not accept Pull Requests via the Github mirror.
The Developer Mailing list is repo-discuss on Google Groups.
Gerrit is provided under the Apache License 2.0.
Install Bazel and run the following:
git clone --recurse-submodules https://gerrit.googlesource.com/gerrit cd gerrit && bazel build release
The instruction how to configure GerritForge/BinTray repositories is here
On Debian/Ubuntu run:
apt-get update && apt-get install gerrit=<version>-<release>
NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.
On CentOS/RedHat run:
yum clean all && yum install gerrit-<version>[-<release>]
On Fedora run:
dnf clean all && dnf install gerrit-<version>[-<release>]
Docker images of Gerrit are available on DockerHub
To run a CentOS 8 based Gerrit image:
docker run -p 8080:8080 gerritcodereview/gerrit[:version]-centos8
To run a Ubuntu 20.04 based Gerrit image:
docker run -p 8080:8080 gerritcodereview/gerrit[:version]-ubuntu20
NOTE: release is optional. Last released package of the version is installed if the release number is omitted.